feat: add github connection #1613
+708
−31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <script setup lang="ts"> | ||
| const route = useRoute() | ||
| const { isConnected, user, login, logout } = useGitHub() | ||
|
|
||
| function handleConnect() { | ||
| login(route.fullPath) | ||
| } | ||
| </script> | ||
|
|
||
| <template> | ||
| <Modal :modalTitle="$t('auth.github.title')" class="max-w-lg" id="github-modal"> | ||
| <!-- Connected state --> | ||
| <div v-if="isConnected && user" class="space-y-4"> | ||
| <div class="flex items-center gap-3 p-4 bg-bg-subtle border border-border rounded-lg"> | ||
| <span class="w-3 h-3 rounded-full bg-green-500" aria-hidden="true" /> | ||
| <div> | ||
| <p class="font-mono text-xs text-fg-muted"> | ||
| {{ $t('auth.github.connected_as', { username: user.username }) }} | ||
| </p> | ||
| </div> | ||
| </div> | ||
| <ButtonBase class="w-full" @click="logout"> | ||
| {{ $t('auth.modal.disconnect') }} | ||
| </ButtonBase> | ||
| </div> | ||
|
|
||
| <!-- Disconnected state --> | ||
| <div v-else class="space-y-4"> | ||
| <p class="text-sm text-fg-muted">{{ $t('auth.github.connect_prompt') }}</p> | ||
| <ButtonBase | ||
| variant="primary" | ||
| class="w-full" | ||
| classicon="i-simple-icons:github" | ||
| @click="handleConnect" | ||
| > | ||
| {{ $t('auth.modal.connect') }} | ||
| </ButtonBase> | ||
| </div> | ||
| </Modal> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| function login(redirectTo?: string) { | ||
| const query: Record<string, string> = {} | ||
| if (redirectTo) { | ||
| query.returnTo = redirectTo | ||
| } | ||
| navigateTo( | ||
| { | ||
| path: '/api/auth/github', | ||
| query, | ||
| }, | ||
| { external: true }, | ||
| ) | ||
| } | ||
|
|
||
| export const useGitHub = createSharedComposable(function useGitHub() { | ||
| const { | ||
| data: user, | ||
| pending, | ||
| clear, | ||
| refresh, | ||
| } = useFetch<{ username: string } | null>('/api/auth/github/session', { | ||
| server: false, | ||
| immediate: !import.meta.test, | ||
| }) | ||
|
|
||
| const isConnected = computed(() => !!user.value?.username) | ||
|
|
||
| async function logout() { | ||
| await $fetch('/api/auth/github/session', { | ||
| method: 'delete', | ||
| }) | ||
|
|
||
| clear() | ||
| } | ||
|
|
||
| return { user, isConnected, pending, logout, login, refresh } | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import type { RepoRef } from '#shared/utils/git-providers' | ||
|
|
||
| type StarStatus = { | ||
| starred: boolean | ||
| connected: boolean | ||
| } | ||
|
|
||
| export function useGitHubStar(repoRef: Ref<RepoRef | null>) { | ||
| const { isConnected } = useGitHub() | ||
|
|
||
| const isGitHubRepo = computed(() => repoRef.value?.provider === 'github') | ||
| const owner = computed(() => repoRef.value?.owner ?? '') | ||
| const repo = computed(() => repoRef.value?.repo ?? '') | ||
|
|
||
| const shouldFetch = computed( | ||
| () => isConnected.value && isGitHubRepo.value && !!owner.value && !!repo.value, | ||
| ) | ||
|
|
||
| const { data: starStatus, refresh } = useFetch<StarStatus>( | ||
| () => `/api/github/starred?owner=${owner.value}&repo=${repo.value}`, | ||
| { | ||
| server: false, | ||
| immediate: false, | ||
| default: () => ({ starred: false, connected: false }), | ||
| watch: false, | ||
| }, | ||
| ) | ||
|
Comment on lines
+19
to
+27
Contributor
There was a problem hiding this comment. Query parameters are not URL-encoded.
Suggested fix using query object- const { data: starStatus, refresh } = useFetch<StarStatus>(
- () => `/api/github/starred?owner=${owner.value}&repo=${repo.value}`,
- {
- server: false,
- immediate: false,
- default: () => ({ starred: false, connected: false }),
- watch: false,
- },
- )
+ const { data: starStatus, refresh } = useFetch<StarStatus>(
+ '/api/github/starred',
+ {
+ server: false,
+ immediate: false,
+ default: () => ({ starred: false, connected: false }),
+ watch: false,
+ query: computed(() => ({ owner: owner.value, repo: repo.value })),
+ },
+ ) |
||
|
|
||
| watch( | ||
| shouldFetch, | ||
| async value => { | ||
| if (value) { | ||
| await refresh() | ||
| } | ||
| }, | ||
| { immediate: true }, | ||
| ) | ||
|
|
||
| const isStarred = computed(() => starStatus.value?.starred ?? false) | ||
| const isStarActionPending = shallowRef(false) | ||
|
|
||
| async function toggleStar() { | ||
| if (!shouldFetch.value || isStarActionPending.value) return | ||
|
|
||
| const currentlyStarred = isStarred.value | ||
|
|
||
| // Optimistic update | ||
| starStatus.value = { | ||
| starred: !currentlyStarred, | ||
| connected: true, | ||
| } | ||
|
|
||
| isStarActionPending.value = true | ||
|
|
||
| try { | ||
| const result = await $fetch<{ starred: boolean }>('/api/github/star', { | ||
| method: currentlyStarred ? 'DELETE' : 'PUT', | ||
| body: { owner: owner.value, repo: repo.value }, | ||
| }) | ||
|
|
||
| starStatus.value = { starred: result.starred, connected: true } | ||
| } catch { | ||
| // Revert on error | ||
| starStatus.value = { | ||
| starred: currentlyStarred, | ||
| connected: true, | ||
| } | ||
| } finally { | ||
| isStarActionPending.value = false | ||
| } | ||
| } | ||
|
|
||
| return { | ||
| isStarred, | ||
| isStarActionPending, | ||
| isGitHubRepo, | ||
| toggleStar, | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.