feat: use/support algolia for package search and org/user package listing#174
Closed
Haroenv wants to merge 2 commits intonpmx-dev:mainfrom
Closed
feat: use/support algolia for package search and org/user package listing#174Haroenv wants to merge 2 commits intonpmx-dev:mainfrom
Haroenv wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
@Haroenv is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
Haroenv
commented
Jan 27, 2026
| return promise | ||
| } | ||
|
|
||
| const ALGOLIA_SEARCH = true |
Contributor
Author
There was a problem hiding this comment.
put in a proper global flags system
| .then(({ results }) => { | ||
| const response = results[0] as SearchResponse<AlgoliaSearchResult> | ||
| return { | ||
| objects: response.hits.map<NpmSearchResult>(hit => ({ |
Contributor
Author
There was a problem hiding this comment.
clean this mapping a bit, somewhat superfluous now.
| searchInputRef.value?.focus() | ||
| }) | ||
|
|
||
| const ALGOLIA = true |
Contributor
Author
There was a problem hiding this comment.
put in a proper global flags system
| </button> | ||
| <!-- Hidden submit button for accessibility (form must have submit button per WCAG) --> | ||
| <button type="submit" class="sr-only">{{ t('search.button') }}</button> | ||
| <button type="submit" class="sr-only"> |
Contributor
Author
There was a problem hiding this comment.
undo auto-formatting?
danielroe
changed the title
danielroe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #32
This is just a prototype to see what it takes to swap out the search for Algolia.
DONE:
TODO:
What do you think?