Skip to content

fix(i18n): update Japanese translations #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphieros merged 1 commit into from
Mar 13, 2026
Merged

fix(i18n): update Japanese translations #2066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions i18n/locales/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,17 @@
"error": "エラー",
"view_on": {
"npm": "npmで表示",
"github": "GitHubで表示"
"github": "GitHubで表示",
"gitlab": "GitLabで表示",
"bitbucket": "Bitbucketで表示",
"codeberg": "Codebergで表示",
"git_repo": "Gitリポジトリで表示",
"forgejo": "Forgejoで表示",
"gitea": "Giteaで表示",
"gitee": "Giteeで表示",
"radicle": "Radicleで表示",
"sourcehut": "SourceHutで表示",
"tangled": "Tangledで表示"
}
},
"profile": {
Expand Down Expand Up @@ -379,6 +389,7 @@
"grouping_versions_only_recent": "直近のみ",
"grouping_usage_title": "使用状況",
"grouping_usage_all": "すべて",
"grouping_usage_most_used": "最多使用",
"recent_versions_only_tooltip": "過去1年以内に公開されたバージョンのみ表示します。",
"show_low_usage_tooltip": "総ダウンロード数の1%未満のバージョングループも含めます。",
"y_axis_label": "ダウンロード",
Expand Down Expand Up @@ -458,6 +469,7 @@
"data_correction": "データ補正",
"average_window": "平均ウィンドウ",
"smoothing": "スムージング",
"prediction": "予測値",
"known_anomalies": "既知のアノマリー",
"known_anomalies_description": "ボットやCIの問題による既知のダウンロードスパイクを補完します。",
"known_anomalies_ranges": "アノマリー範囲",
Expand All @@ -478,7 +490,9 @@
"estimations": "最終値は、現在の期間の部分的データに基づく推定値です。",
"compare": "パッケージダウンロード比較折れ線グラフ: {packages}",
"single_package": "{package} パッケージのダウンロード折れ線グラフ",
"general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位：{granularity}）を示します。{estimation_notice} {packages_analysis}。{watermark}。"
"general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位：{granularity}）を示します。{estimation_notice} {packages_analysis}。{watermark}。",
"facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ({description})。{facet_analysis} {watermark}。",
"facet_bar_analysis": "{package_name} の値は {value} です。"
Comment on lines +493 to +495
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Please align placeholder spacing with the ja-JP interpolation convention.

A few placeholders are still adjacent to punctuation without padding, which breaks the project’s Japanese locale consistency rule.

♻️ Suggested consistency fix 
-        "general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位：{granularity}）を示します。{estimation_notice} {packages_analysis}。{watermark}。",
-        "facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ({description})。{facet_analysis} {watermark}。",
+        "general_description": "Y軸はダウンロード数、X軸は {start_date} から {end_date} までの期間（単位： {granularity} ）を示します。 {estimation_notice} {packages_analysis}。 {watermark} 。",
+        "facet_bar_general_description": "{packages} の横棒グラフ: {facet} の比較 ( {description} )。 {facet_analysis} {watermark}。",

Based on learnings: In all Japanese translation files (ja-JP.json), placeholders like {about}, {app}, {username} should be padded with spaces around interpolated values for consistency.

Copy link
Copy Markdown
Member Author

@shuuji3 shuuji3 Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. These parenthesis, kuten, and touten etc. are special characters usually not padded by spaces in most technical translations in Japanese.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shuuji3, understood and thanks for the clarification. Japanese full-width punctuation such as parentheses（）, kuten（。）, and touten（、）are indeed typically not padded with spaces in Japanese technical text — my suggestion was incorrect to apply the spacing rule there. I'll update my long-term memory accordingly.

✏️ Learnings added 
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 2066
File: i18n/locales/ja-JP.json:493-495
Timestamp: 2026-03-13T19:15:58.472Z
Learning: In Japanese translation files (ja-JP.json) for npmx-dev/npmx.dev, the placeholder space-padding convention does NOT apply when a placeholder is adjacent to Japanese special punctuation characters such as full-width parentheses （）, kuten （。）, touten （、）, or similar CJK punctuation. Space padding is only required when a placeholder has plain Japanese prose text (not punctuation) on both sides. For example, "{granularity} ）" or "{watermark}。" should remain without added spaces around the placeholder.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

🧠 Learnings used 
Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1461
File: lunaria/files/ja-JP.json:1096-1100
Timestamp: 2026-02-13T08:32:50.257Z
Learning: In all Japanese translation files (ja-JP.json), ensure placeholders like {about}, {app}, {username} are padded with spaces around interpolated values to maintain consistency across i18n entries.

Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 1516
File: lunaria/files/ja-JP.json:307-307
Timestamp: 2026-02-15T07:18:37.542Z
Learning: In Japanese translation files for npmx.dev, placeholders at the beginning or end of strings do not need padding on the boundary side. The space padding convention applies to placeholders that have text on both sides (e.g., "text {placeholder} text"), not to placeholders at string boundaries (e.g., "{placeholder} text" or "text {placeholder}").

Learnt from: shuuji3
Repo: npmx-dev/npmx.dev PR: 862
File: lunaria/files/ja-JP.json:175-182
Timestamp: 2026-02-03T16:44:45.205Z
Learning: In Japanese translations for npmx, keep "Issues" in English when it refers to GitHub Issues, as it is GitHub's canonical term for that feature.

Learnt from: serhalp
Repo: npmx-dev/npmx.dev PR: 1183
File: lunaria/files/uk-UA.json:305-318
Timestamp: 2026-02-08T18:44:10.538Z
Learning: In the npmx.dev project, new or changed entries in i18n translation files (locale JSON files) may be omitted from non-English languages. Translations are not completed in-band in the same PR and are tracked elsewhere. It is acceptable for non-English locale files to be missing keys that exist in English locale files.

Learnt from: userquin
Repo: npmx-dev/npmx.dev PR: 1096
File: i18n/locales/es-419.json:34-41
Timestamp: 2026-02-06T14:53:23.339Z
Learning: In the npmx.dev project, when using country locale variants (e.g., es-419, es-ES), place only translations that differ from the base language in variant JSON files (e.g., es-419.json). The base file (es.json) is loaded first, then the variant file overlays any keys it defines. This behavior is provided by vue-i18n's multiple-files feature. See CONTRIBUTING.md under 'Country variants (advanced)' for details.

Learnt from: mikouaji
Repo: npmx-dev/npmx.dev PR: 2029
File: i18n/locales/pl-PL.json:1220-1220
Timestamp: 2026-03-10T21:43:05.255Z
Learning: Treat the locale key pds.community.new_accounts as intentionally lowercase in all locale files under i18n/locales (and by extension the entire npmx-dev/npmx.dev project). Do not flag capitalization for this key in any locale translations. Apply this exception consistently across all locale JSON files (e.g., i18n/locales/*.json) to avoid false positives when reviewing translations.

}
},
"downloads": {
Expand Down Expand Up @@ -1037,7 +1051,9 @@
"loading": "パッケージデータを読み込み中...",
"error": "パッケージデータの読み込みに失敗しました。もう一度お試しください。",
"empty_title": "比較するパッケージを選択",
"empty_description": "上部の検索から2つ以上のパッケージを追加すると、メトリクスを並べて比較できます。"
"empty_description": "上部の検索から2つ以上のパッケージを追加すると、メトリクスを並べて比較できます。",
"table_view": "テーブル",
"charts_view": "グラフ"
},
"selector": {
"search_label": "パッケージを検索",
Expand Down
Loading