fix: normalize metrics language across possible values#2138
fix: normalize metrics language across possible values#2138danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
definitely didn't open this against my own fork first; if you saw that no you didn't 🤫 |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates localisation strings in the English language JSON file. Two metric-related strings are modified: the ES Modules support message is changed from "No ES Modules support" to "ES Modules unsupported", and the TypeScript types support message is changed from "No TypeScript types" to "No types". These changes are made to improve consistency across the localisation values for metrics support indicators. Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
🔗 Linked issue
resolves #2131
🧭 Context
Tiny change to normalize a few strings just to bring the structure of what's being communicated in-line so it's consistent across the board.
Normalizes two strings into the same formats as their peers.
📚 Description
Currently, the tooltip for ESM says
No ESM Supportif there is no ESM butESM Supportedif there is ESM. CJS SaysCJS Supported. This PR normalizes the first to beESM Supportedso it's consistent with the others.The tooltops for Types are
Types included,Types available via {package}, andNo TypeScript types. This PR normalizes the last to be the same as the other two and changes it toNo types.