Skip to content

fix: normalize metrics language across possible values#2138

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
bnb:bnb/update-esm-and-types-in-en-locale
Mar 18, 2026
Merged

fix: normalize metrics language across possible values#2138
danielroe merged 1 commit intonpmx-dev:mainfrom
bnb:bnb/update-esm-and-types-in-en-locale

Conversation

@bnb
Copy link
Copy Markdown
Contributor

@bnb bnb commented Mar 18, 2026

🔗 Linked issue

resolves #2131

🧭 Context

Tiny change to normalize a few strings just to bring the structure of what's being communicated in-line so it's consistent across the board.

Normalizes two strings into the same formats as their peers.

📚 Description

Currently, the tooltip for ESM says No ESM Support if there is no ESM but ESM Supported if there is ESM. CJS Says CJS Supported. This PR normalizes the first to be ESM Supported so it's consistent with the others.

The tooltops for Types are Types included, Types available via {package}, and No TypeScript types. This PR normalizes the last to be the same as the other two and changes it to No types.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 18, 2026 6:54pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 18, 2026 6:54pm
npmx-lunaria Ignored Ignored Mar 18, 2026 6:54pm

Request Review

@bnb
Copy link
Copy Markdown
Contributor Author

bnb commented Mar 18, 2026

definitely didn't open this against my own fork first; if you saw that no you didn't 🤫

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8beb0f8a-eddb-4a7b-b9a2-0b28051a7e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 77c4570 and 3cb2a58.

📒 Files selected for processing (1)
  • i18n/locales/en.json

📝 Walkthrough

Walkthrough

The pull request updates localisation strings in the English language JSON file. Two metric-related strings are modified: the ES Modules support message is changed from "No ES Modules support" to "ES Modules unsupported", and the TypeScript types support message is changed from "No TypeScript types" to "No types". These changes are made to improve consistency across the localisation values for metrics support indicators.

Suggested reviewers

  • 9romise
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the normalisation of two localisation strings for ESM and Types tooltips.
Linked Issues check ✅ Passed The PR directly addresses all requirements from issue #2131: normalises ESM tooltip from 'No ESM Support' to 'ESM Supported' and changes Types tooltip from 'No TypeScript types' to 'No types'.
Out of Scope Changes check ✅ Passed All changes are limited to the English localisation file with only the two specified tooltip strings modified, remaining entirely within the scope of issue #2131.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@danielroe danielroe changed the title doc: normalize metrics language across possible values fix: normalize metrics language across possible values Mar 18, 2026
@danielroe danielroe added this pull request to the merge queue Mar 18, 2026
Merged via the queue into npmx-dev:main with commit 5d8fcf5 Mar 18, 2026
20 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

English Localization for ESM and Types support should be consistent across possible values

2 participants