Skip to content

fix(ui): skeleton design not aligned between states #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatteoGabriele merged 3 commits into from
Mar 21, 2026
Merged

fix(ui): skeleton design not aligned between states #2177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb51af0
fix(ui): skeleton design not aligned between states
MatteoGabriele Mar 21, 2026
254462d
feat: remove extra padding
MatteoGabriele Mar 21, 2026
235de19
refactor: get as close as possible to loaded state
MatteoGabriele Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions app/components/Package/Skeleton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,22 @@

<template>
<!-- Package header — matches area-header in [...name].vue -->
<header class="bg-[--bg] pt-5 pb-1 w-full container">
<div class="min-w-0">
<!-- Package name -->
<div class="min-w-0 flex items-center gap-2 justify-between">
<h1 class="font-mono text-2xl sm:text-3xl font-medium">
<SkeletonInline class="block! h-9 w-48" />
</h1>
<div class="flex gap-1">
<!-- Compare placeholder -->
<SkeletonBlock class="w-9 md:w-40 h-9 rounded self-baseline" />
<!-- Likes button placeholder -->
<SkeletonBlock class="w-14 h-9 rounded self-baseline" />
</div>
<header class="bg-bg pt-6 pb-2 pb-1 w-full container">
<!-- Package name -->
<div class="flex items-baseline justify-between gap-x-2 gap-y-1 flex-wrap min-w-0">
<h1 class="font-mono text-2xl sm:text-3xl font-medium">
<SkeletonInline class="block! h-9 w-48" />
</h1>
<div class="flex gap-2 flex-wrap items-stretch">
<!-- Compare placeholder -->
<SkeletonBlock class="w-9 md:w-36 h-9 rounded" />
<!-- Likes button placeholder -->
<SkeletonBlock class="w-14 h-9 rounded" />
</div>
</div>
</header>

<div class="sticky top-14 z-1 pt-3 bg-bg border-b border-border w-full">
<div class="w-full bg-bg sticky top-14 z-10 border-b border-border pt-2">
<div class="w-full container flex flex-col md:flex-row-reverse flex-wrap gap-2 justify-between">
<!-- Version -->
<span class="inline-flex items-baseline font-mono text-base sm:text-lg shrink-0">
Expand Down Expand Up @@ -176,7 +174,7 @@
<!-- Sidebar — matches area-sidebar in [...name].vue -->
<div class="area-sidebar">
<div
class="sticky top-30 xl:top-14 space-y-6 sm:space-y-8 min-w-0 overflow-y-auto pe-2.5 lg:(max-h-[calc(100dvh-8.5rem)] overscroll-contain) xl:(max-h-[calc(100dvh-6rem)])"
class="space-y-6 sm:space-y-8 min-w-0 lg:(max-h-[calc(100dvh-8.5rem)] overscroll-contain) xl:(max-h-[calc(100dvh-6rem)])"
>
<div class="flex flex-col gap-4 sm:gap-6 xl:pt-4">
<!-- Download stats — matches CollapsibleSection + sparkline skeleton -->
Expand Down
Loading