Skip to content

fix: add top margin to show more/fewer maintainers button#2262

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
iiio2:style/add-top-margin-to-show-more/fewer-button
Mar 24, 2026
Merged

fix: add top margin to show more/fewer maintainers button#2262
ghostdevv merged 2 commits intonpmx-dev:mainfrom
iiio2:style/add-top-margin-to-show-more/fewer-button

Conversation

@iiio2
Copy link
Copy Markdown
Contributor

@iiio2 iiio2 commented Mar 24, 2026

The "show more" / "show fewer" button in the Maintainers section had no top margin, so it appeared visually cramped directly against the last maintainer in the list. Adding mt-2 gives it breathing room from the list above.

Before After After
old new-more new-fewer

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 24, 2026 3:39pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 24, 2026 3:39pm
npmx-lunaria Ignored Ignored Mar 24, 2026 3:39pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df7a5eeb-e177-4553-93a1-ab9817fec890

📥 Commits

Reviewing files that changed from the base of the PR and between 6ead0a8 and 31dee4e.

📒 Files selected for processing (1)
  • app/components/Package/Maintainers.vue

📝 Walkthrough

Walkthrough

This pull request adds a class="mt-2" styling attribute to a "Show more/less" button toggle in the Maintainers component. The styling attribute applies only when the button is visible under the condition !canManageOwners && hiddenMaintainersCount > 0. The change is purely presentational and does not modify any logic, state management, or control flow.

Suggested reviewers

  • danielroe
  • alexdln
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the change: adding mt-2 margin to the show more/fewer button for better visual spacing, with before/after images demonstrating the improvement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv ghostdevv enabled auto-merge March 24, 2026 15:38
@ghostdevv ghostdevv disabled auto-merge March 24, 2026 15:38
@ghostdevv ghostdevv changed the title style: add top margin to show more/fewer button fix: add top margin to show more/fewer button on package page Mar 24, 2026
@ghostdevv ghostdevv changed the title fix: add top margin to show more/fewer button on package page fix: add top margin to show more/fewer maintainers button Mar 24, 2026
@ghostdevv ghostdevv enabled auto-merge March 24, 2026 15:39
@ghostdevv ghostdevv added this pull request to the merge queue Mar 24, 2026
Merged via the queue into npmx-dev:main with commit 781b407 Mar 24, 2026
22 checks passed
@github-actions github-actions bot mentioned this pull request Mar 24, 2026
@iiio2
Copy link
Copy Markdown
Contributor Author

iiio2 commented Mar 24, 2026

Thanks.

@iiio2 iiio2 deleted the style/add-top-margin-to-show-more/fewer-button branch March 24, 2026 15:49
ghostdevv added a commit that referenced this pull request Mar 29, 2026
Co-authored-by: Willow (GHOST) <git@willow.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants