-
-
Notifications
You must be signed in to change notification settings - Fork 400
ci: auto-remove needs review label when PR is reviewed
#2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9abce4a
ci: add workflow that removes `needs review` on review
serhalp 8bb9eb5
Merge branch 'main' into ci/remove-needs-review-label-on-pr-review
serhalp 05183de
ci: use GH API to get reviewer permissions
serhalp 962e9b3
ci: add missing worflow permission
serhalp bcbe235
ci: ignore self-reviews and bot reviews
serhalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| name: remove-needs-review-on-review | ||
|
|
||
| on: | ||
| pull_request_review: | ||
| types: | ||
| - submitted | ||
|
|
||
| jobs: | ||
| remove-needs-review: | ||
| name: π·οΈ Remove needs review label | ||
| if: github.repository == 'npmx-dev/npmx.dev' | ||
| runs-on: ubuntu-slim | ||
| permissions: | ||
| contents: read | ||
| issues: write | ||
| pull-requests: write | ||
| steps: | ||
| - name: π·οΈ Remove needs review label | ||
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 | ||
| with: | ||
| script: | | ||
| const pr = context.payload.pull_request; | ||
| const review = context.payload.review; | ||
| const LABEL = 'needs review'; | ||
| const reviewer = review?.user?.login; | ||
| const author = pr.user?.login; | ||
| const reviewerType = review?.user?.type; | ||
|
|
||
| if (!reviewer) { | ||
| console.log('No reviewer login found in payload, skipping.'); | ||
| return; | ||
| } | ||
|
|
||
| if (reviewerType === 'Bot') { | ||
| console.log(`Skipping bot review from @${reviewer} on PR #${pr.number}.`); | ||
| return; | ||
| } | ||
|
|
||
| if (reviewer === author) { | ||
| console.log(`Skipping self-review from @${reviewer} on PR #${pr.number}.`); | ||
| return; | ||
| } | ||
|
|
||
| if (!pr.labels.some(({ name }) => name === LABEL)) { | ||
| console.log(`PR #${pr.number} does not have the "${LABEL}" label.`); | ||
| return; | ||
| } | ||
|
|
||
| const { data: permission } = await github.rest.repos.getCollaboratorPermissionLevel({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| username: reviewer, | ||
| }); | ||
|
|
||
| console.log(`Reviewer @${reviewer} permission is "${permission.permission}".`); | ||
|
|
||
| if (!['admin', 'maintain', 'write'].includes(permission.permission)) { | ||
| console.log(`Reviewer @${reviewer} is not a maintainer, skipping.`); | ||
| return; | ||
| } | ||
|
|
||
| await github.rest.issues.removeLabel({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: pr.number, | ||
| name: LABEL, | ||
| }); | ||
|
|
||
| console.log(`Removed "${LABEL}" from PR #${pr.number}.`); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.