Skip to content

chore: update artemis noodle range#2424

Merged
serhalp merged 1 commit intonpmx-dev:mainfrom
alexdln:chore/update-noodle-range
Apr 8, 2026
Merged

chore: update artemis noodle range#2424
serhalp merged 1 commit intonpmx-dev:mainfrom
alexdln:chore/update-noodle-range

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented Apr 8, 2026

🔗 Linked issue

Increased visible time for artemis noodle

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 8, 2026 6:47pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 8, 2026 6:47pm
npmx-lunaria Ignored Ignored Apr 8, 2026 6:47pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

The changes extend the noodle feature to support date ranges. The Noodle type in app/components/Noodle/index.ts now includes an optional dateTo field alongside the existing date field. The active noodle selection logic in app/components/Landing/IntroHeader.vue has been updated to perform range matching when a dateTo value is present, whilst maintaining single-date matching for noodles without an end date. The artemis noodle entry has been configured with a start and end date window.

Possibly related PRs

  • feat: noodles #2421: Introduces the noodle feature that this PR extends by adding date range support and updating the filtering logic within the same type and code paths.

Suggested reviewers

  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly relates to the changeset, which updates the artemis noodle's date range to increase its visible time window.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 400b8a14-77f3-43e3-8905-7f88747f3520

📥 Commits

Reviewing files that changed from the base of the PR and between ed72177 and 19936e3.

📒 Files selected for processing (2)
  • app/components/Landing/IntroHeader.vue
  • app/components/Noodle/index.ts

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@serhalp serhalp added this pull request to the merge queue Apr 8, 2026
Merged via the queue into npmx-dev:main with commit ad7b241 Apr 8, 2026
24 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants