Skip to content

chore: improve intro section size#2426

Merged
alexdln merged 1 commit intonpmx-dev:mainfrom
alexdln:chore/intro-section-size
Apr 8, 2026
Merged

chore: improve intro section size#2426
alexdln merged 1 commit intonpmx-dev:mainfrom
alexdln:chore/intro-section-size

Conversation

@alexdln
Copy link
Copy Markdown
Member

@alexdln alexdln commented Apr 8, 2026

🧭 Context

Because the first section was too tall, the moon was displayed too low on mobile devices. Fixed this by correcting section size (dvh instead of vh and subtracted the height of the header)

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 8, 2026 8:52pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 8, 2026 8:52pm
npmx-lunaria Ignored Ignored Apr 8, 2026 8:52pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c750a868-29ad-436f-ae24-9bd269323d10

📥 Commits

Reviewing files that changed from the base of the PR and between ed72177 and 84013a7.

📒 Files selected for processing (1)
  • app/pages/index.vue

📝 Walkthrough

Walkthrough

The hero section layout in the top-level page component has been modified to adjust its minimum height calculation. The sizing utility was changed from min-h-screen to min-h-[calc(100dvh-3.5rem)] to account for a fixed header offset. The flex layout structure and overflow behaviour of the section remain unchanged.

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly addresses the changeset by explaining that the viewport height issue (vh !== dvh) on mobile devices is being fixed by updating the hero section sizing.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexdln alexdln added this pull request to the merge queue Apr 8, 2026
Merged via the queue into npmx-dev:main with commit e5fafc1 Apr 8, 2026
23 checks passed
@alexdln alexdln deleted the chore/intro-section-size branch April 8, 2026 21:00
@github-actions github-actions bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants