Skip to content

fix: pass query params to OG image ISR function on Vercel #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdln merged 5 commits into from
Apr 9, 2026
+8 −1
Merged

fix: pass query params to OG image ISR function on Vercel #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a53564
fix: pass query params to OG image ISR function on Vercel
Adebesin-Cell Apr 9, 2026
b828bce
fix: add allowQuery whitelist for OG image ISR cache
Adebesin-Cell Apr 9, 2026
2dd81c2
fix: scope query passthrough to compare OG image route only
Adebesin-Cell Apr 9, 2026
bc19494
fix: sort packages in OG image to normalize cache keys
Adebesin-Cell Apr 9, 2026
7527c51
Merge branch 'main' into fix/og-image-pass-query
Adebesin-Cell Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pages/compare.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ async function exportComparisonDataAsMarkdown() {
}
defineOgImageComponent('Compare', {
packages: () => packages.value,
packages: () => packages.value.toSorted((a, b) => a.localeCompare(b)),
emptyDescription: () => $t('compare.packages.meta_description_empty'),
})
Expand Down
7 changes: 7 additions & 0 deletions nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ export default defineNuxtConfig({
'/:pkg/.well-known/skills/**': { isr: 3600 },
'/:scope/:pkg/.well-known/skills/**': { isr: 3600 },
'/__og-image__/**': getISRConfig(3600),
'/__og-image__/image/compare/**': {
isr: {
expiration: 3600,
passQuery: true,
allowQuery: ['packages', '_query'],
},
},
'/_avatar/**': { isr: 3600, proxy: 'https://www.gravatar.com/avatar/**' },
'/opensearch.xml': { isr: true },
'/oauth-client-metadata.json': { prerender: true },
Expand Down
Loading