Skip to content

fix(i18n): add missing French translations#2441

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
juliendargelos:main
Apr 9, 2026
Merged

fix(i18n): add missing French translations#2441
ghostdevv merged 1 commit intonpmx-dev:mainfrom
juliendargelos:main

Conversation

@juliendargelos
Copy link
Copy Markdown
Contributor

🔗 Linked issue

No linked issue

🧭 Context

French translations for the following keys are missing:

common.yes
common.no
common.view_on.socket_dev
code.copy_content
code.toggle_container
code.open_raw_file

This PR adds translations for those keys.

📚 Description

French translations have been added for the keys listed above.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Apr 9, 2026 5:55pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 9, 2026 5:55pm
npmx-lunaria Ignored Ignored Apr 9, 2026 5:55pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

This pull request adds French language translations to the French locale file. The changes introduce six new i18n string entries: common boolean labels (common.yes and common.no), a new external source link entry for socket.dev under the view-on section, and three code viewer UI control labels for copying content, toggling container width, and opening raw files. All additions are translation entries with no code modifications.

Suggested reviewers

  • graphieros
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the purpose: adding missing French translations for six specific i18n keys, with context about which keys are being translated.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
i18n/locales/fr-FR.json (1)

946-946: Consider "Basculer" for consistency with other toggle actions.

Whilst "Changer la largeur du conteneur" is understandable, other toggle actions in this file use "Basculer" (e.g., Line 941: "toggle_tree": "Basculer l'arborescence", Line 619: "toggle_stack_mode": "Basculer le mode empilé"). For consistency, consider:

♻️ Proposed refactor for consistency
-    "toggle_container": "Changer la largeur du conteneur",
+    "toggle_container": "Basculer la largeur du conteneur",

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c79ab8b0-bc4c-4a6b-92c2-392a51ae1060

📥 Commits

Reviewing files that changed from the base of the PR and between 5a2b1a6 and 52a3f47.

📒 Files selected for processing (1)
  • i18n/locales/fr-FR.json

@juliendargelos juliendargelos changed the title feat(i18n): Add missing French translations feat(i18n): add missing French translations Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@juliendargelos
Copy link
Copy Markdown
Contributor Author

juliendargelos commented Apr 9, 2026

🧹 Nitpick comments (1)

i18n/locales/fr-FR.json (1)> 946-946: Consider "Basculer" for consistency with other toggle actions.

Whilst "Changer la largeur du conteneur" is understandable, other toggle actions in this file use "Basculer" (e.g., Line 941: "toggle_tree": "Basculer l'arborescence", Line 619: "toggle_stack_mode": "Basculer le mode empilé"). For consistency, consider:

♻️ Proposed refactor for consistency

-    "toggle_container": "Changer la largeur du conteneur",
+    "toggle_container": "Basculer la largeur du conteneur",

Here, I chose "Changer" rather than "Basculer" because it seemed more natural in this context.

This is also the verb used for the package.trends.chart_view_toggle key:

"chart_view_toggle": "Changer de vue",

@ghostdevv ghostdevv changed the title feat(i18n): add missing French translations fix(i18n): add missing French translations Apr 9, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Apr 9, 2026
Merged via the queue into npmx-dev:main with commit f58c765 Apr 9, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants