Skip to content

fix(i18n): add missing zh-CN translations#2452

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
DamengRandom:feat/zh-cn-missing-translations
Apr 10, 2026
Merged

fix(i18n): add missing zh-CN translations#2452
ghostdevv merged 2 commits intonpmx-dev:mainfrom
DamengRandom:feat/zh-cn-missing-translations

Conversation

@DamengRandom
Copy link
Copy Markdown
Contributor

Add 3 missing translation keys for zh-CN locale:

  • common.view_on.socket_dev
  • compare.quadrant_chart.explanation.tooltip_help_adoption
  • compare.quadrant_chart.explanation.tooltip_help_efficiency

🔗 Linked issue

🧭 Context

📚 Description

Add 3 missing translation keys for zh-CN locale:
- common.view_on.socket_dev
- compare.quadrant_chart.explanation.tooltip_help_adoption
- compare.quadrant_chart.explanation.tooltip_help_efficiency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Apr 10, 2026 4:18am
npmx.dev Ready Ready Preview, Comment Apr 10, 2026 4:18am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Apr 10, 2026 4:18am

Request Review

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @DamengRandom! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dfb2dc5f-8a32-45fc-9cc1-0f2e6a1ac55c

📥 Commits

Reviewing files that changed from the base of the PR and between fd7703c and 32eba3b.

📒 Files selected for processing (1)
  • i18n/locales/zh-CN.json

📝 Walkthrough

Walkthrough

This pull request adds three new Chinese localization strings to the i18n/locales/zh-CN.json file. It introduces a new translation key common.view_on.socket_dev for displaying "View on socket.dev" functionality, and extends the compare.quadrant_chart.explanation section by adding two tooltip help strings for adoption score and efficiency score explanations. The change consists of three new translation lines with no removals.

Possibly related PRs

Suggested reviewers

  • danielroe
  • 9romise
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, specifying the three missing translation keys being added to the zh-CN locale.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv changed the title feat(i18n): add missing zh-CN translations fix(i18n): add missing zh-CN translations Apr 10, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Apr 10, 2026
Merged via the queue into npmx-dev:main with commit 6c6e274 Apr 10, 2026
21 checks passed
@github-actions
Copy link
Copy Markdown

Thanks for your first contribution, @DamengRandom! 🙌

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants