feat: better contrast for accent colors & visual changes#626
feat: better contrast for accent colors & visual changes#626jellydeck wants to merge 27 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
jellydeck
changed the title
|
These are starting to look better in terms of consistency but I checked out the deployment and the colours chosen for focus outlines do still fail colour contrast. Before I saw this PR I actually opened this issue for reference. |
|
This is looking specifically at the provenance icon in dark mode. 
|
default accent-color otherwise half opacity
|
@whitep4nth3r I think accent would work great here, what do you think? |
|
There's actually another PR going on over here for the same thing 😅 |
|
Accent colour could work but I'm not sure if all the colours available in the settings have been tested against the background colours. |
|
would you add an a11y test for the new AppLogo component? 🙏 |
as per dicussion from npmx-dev#650 by @JarvisInvestInsight Co-Authored-By: J.A.R.V.I.S. <258503261+JarvisInvestInsight@users.noreply.github.com>
|
few visual fixes:
|
|
@danielroe have a look on test |
| const accentColors = computed(() => { | ||
| const mode = (colorMode.value || 'dark') as 'light' | 'dark' | ||
| const colors = ACCENT_COLORS[mode] | ||
|
|
||
| return Object.entries(colors).map(([id, value]) => ({ | ||
| id: id as AccentColorId, | ||
| name: id, | ||
| value, | ||
| })) | ||
| }) |
There was a problem hiding this comment.
this is why ci is failing - colors can be undefined
There was a problem hiding this comment.
const colors = ACCENT_COLORS[mode] ?? ACCENT_COLORS.darkthis also doesn't seem to work 2502007
|
moved to #904, since history is mess |
4 participants
closes #611 resolves #633
Major visual change
docs bar is moved below description to accommodate for long package names
