fix(i18n): various rtl and arabic fixes#760
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
this is mostly a workaround, a proper fix is needed.
|
I was going to start fixing some RTL issues, and some Arabic-specific things like the font. But I couldn't make the font work only for Arabic text, especially when there's English words (the original English font will not be used). I also wanted to fix the code section because it doesn't have to be RTL 😅 though I faced many issues with font and other weird bugs so I ditched the idea. Are you gonna work on any of those fixes? |
|
Oh yes, already switched the code portions to be LTR and made the README direction automatic among others, but haven't committed yet. Hopefully will add a few other things in this PR today, mostly layout fixes and other minor things. As for adding a font for Arabic, we should have that as a separate PR. Feel free to open one if you manage to get it working! Ideally we want it to act as a "fallback", where the original font is prioritized but missing glyphs fall back onto the Arabic font. Not sure how feasible that is in the web, will hopefully look into it after this. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
better fix implemented in npmx-dev#1055
|
where is |
|
@userquin yeah I'll open a separate PR for missing keys. |
|
would you be able to resolve the conflicts? 🙏 |
|
resolved 👍🏻 |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/pages/package/[[org]]/[name].vue (1)
556-568:⚠️ Potential issue | 🟡 Minor
requestedVersionat line 557 is missingdir="ltr"whilstresolvedVersionhas it.When a version is resolved (e.g.,
latest → 4.2.0), the resolved version on lines 565 and 568 correctly hasdir="ltr", but therequestedVersionspan on line 557 does not. The requested version can be a semver range like^4.0.0or~2.1whose punctuation characters may render incorrectly in RTL contexts.🛠️ Proposed fix
- <span class="font-mono text-fg-muted text-sm">{{ requestedVersion }}</span> + <span class="font-mono text-fg-muted text-sm" dir="ltr">{{ requestedVersion }}</span>
Fixing various RTL issues:
built_atstring....with…to avoid odd ligature behavior, at least until a proper fix is implemented.dir="ltr", as they look odd or broken in rtl.dir="ltr".package.links.codefor its title, instead of hardcoded English string.Draft, will commit more fixes so it's all merged in one go.Done!