Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe CI workflow configuration has been updated to consolidate testing steps. The unit test step has been renamed and its command modified to execute both unit and component tests simultaneously with coverage reporting using Vite. The previously separate component tests step has been removed. A new step for uploading coverage reports to Codecov has been added to the workflow. The net effect involves combining test execution into a single step whilst adding external coverage report integration. 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
67-69: Consider adding the Codecov token for more reliable uploads and to support protected branches.The
codecov/codecov-action@v5supports tokenless uploads for public repositories on unprotected branches, but a token is required for protected branches (such asmain) in public repositories and is mandatory for private repositories. Even for unprotected branches, adding the token improves upload reliability and prevents rate-limiting issues.♻️ Proposed improvement
- name: Upload coverage reports to Codecov uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5 + with: + token: ${{ secrets.CODECOV_TOKEN }}
| - name: 🧪 Unit and component tests | ||
| run: pnpm vite test run --coverage |
There was a problem hiding this comment.
Incorrect command: vite does not have a test subcommand.
The command pnpm vite test run --coverage is invalid. vite is the build tool; the test runner is vitest. This will fail at runtime.
🐛 Proposed fix
- name: 🧪 Unit and component tests
- run: pnpm vite test run --coverage
+ run: pnpm vitest run --coverageAlternatively, if there's an existing npm script:
- name: 🧪 Unit and component tests
- run: pnpm vite test run --coverage
+ run: pnpm test:unit --coverage📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: 🧪 Unit and component tests | |
| run: pnpm vite test run --coverage | |
| - name: 🧪 Unit and component tests | |
| run: pnpm vitest run --coverage |
|
@danielroe 👀 this doesn't appear to be working. You'll need to log in to Codecov and get the token to include in the CI workflow, I think. See https://github.com/npmx-dev/npmx.dev/actions/runs/21633953817/job/62353964912#step:9:269: |
resolves #589