fix: direct & total dependency count

[shamilkotta]

fixes #857

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Error		Feb 3, 2026 7:15pm
npmx.dev	Ready	Preview, Comment	Feb 3, 2026 7:15pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
npmx-lunaria	Ignored		Feb 3, 2026 7:15pm

[coderabbitai]

📝 Walkthrough

Walkthrough

A new directDepCount field was added to install-size results and to PackageComparisonData. Server-side install-size calculation now returns directDepCount alongside selfSize, totalSize and dependencyCount. The Dependencies facet now reads installSize.directDepCount for raw, display and status values. The totalDependencies facet no longer carries comingSoon in FACET_INFO and, when installSize exists, computes from installSize.dependencyCount. Tests were updated to derive coming-soon facets from FACET_INFO at runtime.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description 'fixes #857' is minimal but directly related to the changeset, which addresses issues in the package comparison table regarding direct and total dependency counts.
Linked Issues check	✅ Passed	All coding requirements from issue #857 are met: directDepCount field added to track direct dependencies [857], totalDependencies facet implemented with comingSoon flag removed [857], and dependencies facet now uses directDepCount instead of total count [857].
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the direct/total dependency count issues. Test file updates dynamically reference FACET_INFO to maintain proper test coverage without hard-coding facet names, which is a reasonable supporting change.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/composables/usePackageComparison.ts (1)

363-390: ⚠️ Potential issue | 🟠 Major

Wrap ALL switch cases with const declarations in blocks to satisfy Biome's noSwitchDeclarations.

The rule is enabled by default in the current Biome configuration (via "recommended": true). Five cases violate this rule and require block-scoped wrapping: 'lastUpdated', 'license', 'deprecated', 'dependencies', and 'totalDependencies'.

Proposed fix

    case 'lastUpdated':
+   {
      if (!data.metadata?.lastUpdated) return null
      const date = new Date(data.metadata.lastUpdated)
      return {
        raw: date.getTime(),
        display: data.metadata.lastUpdated,
        status: isStale(date) ? 'warning' : 'neutral',
        type: 'date',
      }
+   }

    case 'license':
+   {
      const license = data.metadata?.license
      if (!license) {
        return { raw: null, display: t('compare.facets.values.unknown'), status: 'warning' }
      }
      return {
        raw: license,
        display: license,
        status: 'neutral',
      }
+   }

    case 'dependencies':
+   {
      if (!data.installSize) return null
      const directDepCount = data.installSize.directDepCount
      return {
        raw: directDepCount,
        display: String(directDepCount),
        status: directDepCount > 50 ? 'warning' : 'neutral',
      }
+   }

    case 'deprecated':
+   {
      const isDeprecated = !!data.metadata?.deprecated
      return {
        raw: isDeprecated,
        display: isDeprecated
          ? t('compare.facets.values.deprecated')
          : t('compare.facets.values.not_deprecated'),
        status: isDeprecated ? 'bad' : 'good',
      }
+   }

    case 'totalDependencies':
+   {
      if (!data.installSize) return null
      const depCount = data.installSize.dependencyCount
      return {
        raw: depCount,
        display: String(depCount),
        status: depCount > 50 ? 'warning' : 'neutral',
      }
+   }

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Include totalDependencies in the install-size loading check.
This facet now depends on install-size, but isFacetLoading (Line 231) still omits it, so the UI can show a non-loading state whilst data is pending.

Proposed fix

-    return facet === 'installSize' || facet === 'dependencies'
+    return facet === 'installSize' || facet === 'dependencies' || facet === 'totalDependencies'

🧰 Tools

🪛 Biome (2.3.13)

[error] 385-385: Other switch clauses can erroneously access this declaration.
Wrap the declaration in a block to restrict its access to the switch clause.

The declaration is defined in this switch clause:

Safe fix: Wrap the declaration in a block.

(lint/correctness/noSwitchDeclarations)

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
app/composables/usePackageComparison.ts	0.00%	5 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!