Skip to content

Comments

fix(i18n,ui): add search page title and description#872

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:feat-add-search-title-entries
Feb 3, 2026
Merged

fix(i18n,ui): add search page title and description#872
danielroe merged 2 commits intonpmx-dev:mainfrom
userquin:feat-add-search-title-entries

Conversation

@userquin
Copy link
Member

@userquin userquin commented Feb 3, 2026

This PR includes i18n support for search page title and description:

  • new entries at en.json
  • new entries at es.json
  • change SEO logic at search.vue page

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 8:05pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 3, 2026 8:05pm
npmx-lunaria Ignored Ignored Feb 3, 2026 8:05pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The change localises search page metadata by replacing hardcoded English strings with i18n keys. The app/pages/search.vue component now uses translated keys for SEO title and description and for the Open Graph image title and description, including conditional interpolation when a query is present. New translation keys were added under the search namespace across locale files: i18n/locales/en.json, i18n/locales/es.json, and lunaria locale files (en-GB.json, en-US.json, es-419.json, es-ES.json). No exported API signatures were altered.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description accurately describes the changeset, detailing the addition of i18n support for search page metadata across multiple locale files and the corresponding SEO logic updates in search.vue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe changed the title feat(i18n, ui): add search page title and description fix(i18n,ui): add search page title and description Feb 3, 2026
@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into npmx-dev:main with commit 338b86a Feb 3, 2026
16 checks passed
@userquin userquin deleted the feat-add-search-title-entries branch February 3, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants