Skip to content

Comments

test: reorganise npm unit tests#876

Merged
danielroe merged 1 commit intomainfrom
jg/npm-units
Feb 3, 2026
Merged

test: reorganise npm unit tests#876
danielroe merged 1 commit intomainfrom
jg/npm-units

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Feb 3, 2026

Leftovers from when I moved the utils around.

Leftovers from when I moved the utils around.
@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 8:32pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 3, 2026 8:32pm
npmx-lunaria Ignored Ignored Feb 3, 2026 8:32pm

Request Review

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

This pull request reorganises unit tests for npm utilities. The test file test/unit/app/utils/npm.spec.ts is removed, with its test contents redistributed: buildScopeTeam tests are moved to a new file test/unit/app/utils/npm/common.spec.ts, whilst getSpdxLicenseUrl tests are relocated to test/unit/shared/utils/spdx.spec.ts. The spdx test file receives expanded coverage with additional license identifiers and edge cases. No runtime code changes are introduced.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset as reorganising unit tests and cleaning up leftovers from moving utilities.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/npm-units

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit b569b70 Feb 3, 2026
17 checks passed
@danielroe danielroe deleted the jg/npm-units branch February 3, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants