Skip to content

fix(ui): add missing AppTooltip usages #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 3, 2026
Merged

fix(ui): add missing AppTooltip usages #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af265e2
fix(client): add missing AppTooltip usages
sybers Feb 3, 2026
d61e10b
fix(ui): remove duplicated whitespace classes in base tooltip
sybers Feb 3, 2026
c98dc66
Merge branch 'main' into fix/add-missing-app-tooltips
danielroe Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/components/Terminal/Install.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,12 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
<NuxtLink
:to="`/package/${createPackageInfo.packageName}`"
class="text-fg-muted hover:text-fg text-xs transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-fg/50 rounded"
:title="$t('package.create.view', { packageName: createPackageInfo.packageName })"
>
<span class="i-carbon:information w-3 h-3 mt-1" aria-hidden="true" />
<TooltipApp
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
>
<span class="i-carbon:information w-3 h-3 mt-1" aria-hidden="true" />
</TooltipApp>
<span class="sr-only">{{
$t('package.create.view', { packageName: createPackageInfo.packageName })
}}</span>
Expand Down
2 changes: 1 addition & 1 deletion app/components/Tooltip/Base.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const { floatingStyles } = useFloating(triggerRef, tooltipRef, {
<div
v-if="props.isVisible"
ref="tooltipRef"
class="px-2 py-1 font-mono text-xs text-fg bg-bg-elevated border border-border rounded shadow-lg whitespace-nowrap z-[100] pointer-events-none"
class="px-2 py-1 font-mono text-xs text-fg bg-bg-elevated border border-border rounded shadow-lg whitespace-pre-line z-[100] pointer-events-none"
:style="floatingStyles"
v-bind="tooltipAttr"
>
Expand Down
8 changes: 3 additions & 5 deletions app/pages/package/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,11 +861,9 @@ defineOgImageComponent('Package', {
<div class="space-y-1 sm:col-span-3">
<dt class="text-xs text-fg-subtle uppercase tracking-wider flex items-center gap-1">
{{ $t('package.stats.install_size') }}
<span
class="i-carbon:information w-3 h-3 text-fg-subtle"
aria-hidden="true"
:title="sizeTooltip"
/>
<TooltipApp :text="sizeTooltip">
<span class="i-carbon:information w-3 h-3 text-fg-subtle" aria-hidden="true" />
</TooltipApp>
</dt>
<dd class="font-mono text-sm text-fg">
<!-- Package size (greyed out) -->
Expand Down
Loading