Skip to content

Comments

feat(i18n): translate callout titles in README#934

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
wojtekmaj:i18n-callouts
Feb 4, 2026
Merged

feat(i18n): translate callout titles in README#934
danielroe merged 5 commits intonpmx-dev:mainfrom
wojtekmaj:i18n-callouts

Conversation

@wojtekmaj
Copy link
Contributor

Closes #259

Copilot AI review requested due to automatic review settings February 4, 2026 12:40
@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 1:10pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 1:10pm
npmx-lunaria Ignored Ignored Feb 4, 2026 1:10pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete.
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/pl-PL.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Adds i18n support for README callout headings by binding CSS custom properties on the Readme component's article element using translated strings (via $t). CSS pseudo‑element content for callouts is changed from hardcoded labels to CSS variables with fallbacks; runtime click behaviour is unchanged. Locale files updated to include a new callout object (note, tip, important, warning, caution) in English and Polish variants, plus package.readme.provenance_section and toc_title additions and a settings.background_themes key in Polish files; some keys were reordered.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is minimalist but clearly references the linked issue #259, which is directly related to the changeset of adding i18n translations for README callout headers.
Linked Issues check ✅ Passed The pull request successfully implements i18n support for README callout headers across multiple locale files and integrates CSS custom properties for runtime translation propagation, fully satisfying issue #259 requirements.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #259: i18n integration for callout translations in README. Minor adjustments to locale file structure (key reordering, new settings fields) are reasonable supporting changes for the translation system.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates README callout UI to use localized titles instead of hard-coded English strings.

Changes:

  • Adds i18n-driven labels for README callout titles (note/tip/important/warning/caution) in Readme.vue.
  • Reorders a couple of JSON keys and adds an empty provenance_section object in Polish locale files.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
lunaria/files/pl-PL.json Reorders keys and adds provenance_section placeholder in Polish translations.
i18n/locales/pl-PL.json Mirrors the same Polish translation structure changes as lunaria/files.
app/components/Readme.vue Replaces hard-coded callout titles with i18n-driven CSS content.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@wojtekmaj wojtekmaj marked this pull request as draft February 4, 2026 12:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 1e17569 Feb 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add translations to readme alert headers

2 participants