Skip to content

Comments

fix: add readme codeblock bg, remove duplicated styles#973

Merged
43081j merged 1 commit intonpmx-dev:mainfrom
mikouaji:fix/update-readme-styles
Feb 4, 2026
Merged

fix: add readme codeblock bg, remove duplicated styles#973
43081j merged 1 commit intonpmx-dev:mainfrom
mikouaji:fix/update-readme-styles

Conversation

@mikouaji
Copy link
Contributor

@mikouaji mikouaji commented Feb 4, 2026

Implements #931
Also removed some duplicated code regarding the code block and its copy button

Before:
image

image

After:
image

image

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 10:43pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 10:43pm
npmx-lunaria Ignored Ignored Feb 4, 2026 10:43pm

Request Review

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the Readme.vue component to remove copy-button functionality and styling from code blocks. The changes eliminate all CSS rules related to the copy button UI, including hover and focus interactions. Explicit display, width, and position declarations in the .readme-code-block rule are replaced with a Tailwind @apply bg-bg-subtle; directive. The code-block base styling remains intact whilst the dedicated .readme-copy-button element styling and related transition rules are removed. No exported public entities were affected. The net change is 1 line added and 42 lines removed.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is directly related to the changeset, referencing issue #931 and explaining the removal of duplicate code related to code blocks and copy buttons.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@43081j 43081j added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit 84d849e Feb 4, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants