Skip to content

Comments

fix: deduplicate when dependencies === transitive dependencies#976

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
gameroman:no-deps-no-duplicate
Feb 5, 2026
Merged

fix: deduplicate when dependencies === transitive dependencies#976
danielroe merged 2 commits intonpmx-dev:mainfrom
gameroman:no-deps-no-duplicate

Conversation

@gameroman
Copy link
Contributor

@gameroman gameroman commented Feb 5, 2026

Before

image {D7F66734-DECA-457E-86D0-DE5DEC93432F}

After

image {3A1D5502-7EDF-49F3-87CE-E38CA7F542B9}

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 0:17am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 0:17am
npmx-lunaria Ignored Ignored Feb 5, 2026 0:17am

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[...package].vue 0.00% 10 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The package page Vue component was updated so the separator between direct and total transitive dependencies and the blocks that show total transitive dependencies and install size are each rendered only when getDependencyCount(displayVersion) indicates dependencies exist. The total-transitive-deps block (spinner, total count or dash) and the install-size block (spinner, bytes or dash) were moved inside conditionals gated by the same dependency-count check. No computation or loading-state logic for totalDepsCount or install-size was changed. (≈46 words)

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description consists of before/after screenshots demonstrating the visual changes to the dependencies and install size display.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman force-pushed the no-deps-no-duplicate branch from 8dd67f8 to fd1d2da Compare February 5, 2026 08:24
@danielroe danielroe changed the title Don't show same info twice when 0 dependencies fix: deduplicate when dependencies === transitive dependencies Feb 5, 2026
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic here should be that if dependencies === transitive dependencies, we only show one number

(rather than being about having zero dependencies)

@gameroman
Copy link
Contributor Author

Yeah, makes sense I guess, will do so when I get home

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit ca38eac Feb 5, 2026
16 of 17 checks passed
@gameroman gameroman deleted the no-deps-no-duplicate branch February 6, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants