timer: drop HV interface, use it less often #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 62.80% 62.76% -0.04%
==========================================
Files 27 27
Lines 1546 1531 -15
==========================================
- Hits 971 961 -10
+ Misses 508 503 -5
Partials 67 67 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Mar 9, 2024
Member
AnnaShaleva
left a comment
AnnaShaleva
left a comment
There was a problem hiding this comment.
Need to add a note to CHANGELOG. The PR itself LGTM.
* HV is not a perfect name * in most cases we can have simpler interface with one/two values * the only problem is LastSeenMessage where we need to have this pair, so it's kept for this purpose only, but with a better name Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
timer-no-hv
branch
from
2f7b9e6 to
262f817
Compare
AnnaShaleva
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look, suggestions are welcome. But I think it's easier to use this way.