contest: expose PreBlock instead of PreHeader #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
From the user's PoW PreBlock should be returned from this method, not PreHeader, otherwise the behaviour is misleading and causes bugs. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
These fields are a part of dBFT context, they should be accessible via those methods that expose Context to the user. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
expose-preblock
branch
from
5d6954c to
abb011f
Compare
roman-khimov
approved these changes
Oct 30, 2024
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Nov 1, 2024
Fetch nspcc-dev/dbft#133. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
to bane-labs/go-ethereum
that referenced
this pull request
Nov 1, 2024
Fetch nspcc-dev/dbft#133. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NeoX node is struggling from inability to receive PreBlock instead of PreHeader.