Go 1.23 #145
Merged
Go 1.23 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to tests here. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's not needed for dbft itself. Signed-off-by: Roman Khimov <roman@nspcc.ru>
dbft doesn't use it, tests can deal with it in another way. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 57.86% 57.77% -0.09%
==========================================
Files 33 33
Lines 2283 2276 -7
==========================================
- Hits 1321 1315 -6
+ Misses 873 872 -1
Partials 89 89 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's not need with Go 1.23+, see https://pkg.go.dev/time#NewTimer Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
go-1.23
branch
from
ff9ce39 to
f7a23ed
Compare
AnnaShaleva
approved these changes
Feb 26, 2025
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Mar 21, 2025
Fetch nspcc-dev/dbft#145. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.