Improve external api #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <roman@nspcc.ru>
* it's missing one method * it doesn't solve any problem, there is exactly one DBFT that implements it and it doesn't provide anything but the dBFT service Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 73.13% 73.02% -0.11%
==========================================
Files 24 24
Lines 1381 1383 +2
==========================================
Hits 1010 1010
- Misses 303 305 +2
Partials 68 68 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Feb 13, 2024
InitializeConsensus was once an internal function, for external use only view zero is relevant, so API should be somewhat more strict. Some shorter name is nice to have as well. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
improve-external-api
branch
from
f3cba97 to
902e6b5
Compare
AnnaShaleva
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.