Add authentication arg to Image#distribution#3
Merged
nu12 merged 1 commit intonu12:masterfrom Dec 6, 2020
Merged
Conversation
Owner
|
Thanks for the PR. I might release a new version to include this new feature during the week. In this meantime, do you have a suggestion on how to test the authentication feature in these three methods without querying Dockerhub? Right now the authentication is not covered by the tests. |
Owner
|
Added issue to deal with the registry authentication: #4 |
Contributor
Author
|
BTW, thanks for your openness and timeliness to merge PRs. You make it easy and pleasant to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an authentication arg to
image.distribution, much like already exists forimage.buildandimage.create.