Add support for namespace override through channel#131
Merged
Conversation
ignacioboud
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
La variable
NAMESPACE_OVERRIDEse usa actualmente para poder definir en forma externa (generalmente desde un notification channel) el namespace de k8s a utilizar en las funcionalidades de logs y métricas.Lo habíamos agregado porque esas funcionalidades no estaban consumiendo data de providers para ser rápido.
Sin embargo, trajo aparejado un feature colateral de que, configurando vía channel se puede usar valores dinámico del estilo
{context.tags.namespace}y, de esa manera, usar distintos namespace de k8s siguiendo la jerarquía de nullplatform.Hace poco agregamos el feature de poder crear el namespace en el cluster cuando no existe, sin embargo, viendo con el cliente, vimos que sería muy útil poder usar este feature en combinación con el
NAMESPACE_OVERRIDEdinámico que soportamos vía channel.Este PR agrega el soporte para las acciones de scope y deployment que no lo tenían.