Merged
Conversation
sebasnallar
approved these changes
Sep 11, 2025
fedemaleh
added a commit
that referenced
this pull request
Sep 12, 2025
* Features/custom domains (#34) * [feature]: custo domains attached to rules * [feature]: service spec * Safe scope delete (#42) * Do not try to delete dns record if no domain * Do not fail if Route53 Record does not exist when deleting scope * Enable IAM for tests * Skip role deletion if it does not exist * Disable IAM role * [feature]: datadog (#38) * [feature]: datadog * remove unwanted metrics from rendering * [fix]: getter for build context * [fix]: use proper service name * [fix]: use proper service name * [fix]: datadog site key * Add support for memory scaling (#44) --------- Co-authored-by: Sebastian Nallar <95891104+sebasnallar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estuvimos teniendo muchos reportes de casos de scopes que no se pueden borrar, esto suele ocurrir cuando un scope no se creó correctamente.
Al realizar el delete suele ocurrir que el DNS o el role de IAM no existen. Este PR agrega lógica para seguir adelante e ignorar errores borrando cosas cuando estas no existen