Skip to content

[fixes][route53]: we create the record on both hosted zones #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebasnallar merged 1 commit into from
Sep 30, 2025
Merged

[fixes][route53]: we create the record on both hosted zones #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions k8s/scope/networking/dns/route53/manage_route
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,16 @@ fi

echo "Found load balancer DNS: $ELB_DNS_NAME"

if [ "$SCOPE_VISIBILITY" = "public" ]; then
HOSTED_ZONES=("$HOSTED_PUBLIC_ZONE_ID")
else
HOSTED_ZONES=()

if [[ -n "$HOSTED_PRIVATE_ZONE_ID" ]] && [[ "$HOSTED_PRIVATE_ZONE_ID" != "null" ]]; then
HOSTED_ZONES+=("$HOSTED_PRIVATE_ZONE_ID")
fi

if [[ -n "$HOSTED_PUBLIC_ZONE_ID" ]] && [[ "$HOSTED_PUBLIC_ZONE_ID" != "null" ]]; then
if [[ "$HOSTED_PUBLIC_ZONE_ID" != "$HOSTED_PRIVATE_ZONE_ID" ]]; then
HOSTED_ZONES+=("$HOSTED_PUBLIC_ZONE_ID")
echo "Will create records in both public and private zones"
fi
HOSTED_ZONES=()

if [[ -n "$HOSTED_PRIVATE_ZONE_ID" ]] && [[ "$HOSTED_PRIVATE_ZONE_ID" != "null" ]]; then
HOSTED_ZONES+=("$HOSTED_PRIVATE_ZONE_ID")
fi

if [[ -n "$HOSTED_PUBLIC_ZONE_ID" ]] && [[ "$HOSTED_PUBLIC_ZONE_ID" != "null" ]]; then
if [[ "$HOSTED_PUBLIC_ZONE_ID" != "$HOSTED_PRIVATE_ZONE_ID" ]]; then
HOSTED_ZONES+=("$HOSTED_PUBLIC_ZONE_ID")
echo "Will create records in both public and private zones"
fi
fi

Expand Down Expand Up @@ -88,4 +84,4 @@ for ZONE_ID in "${HOSTED_ZONES[@]}"; do
}

echo "Successfully $ACTION Route53 record"
done
done