fix(auth): Hide Google login on iOS #3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide Google login button on iOS platforms in both login and signup pages to prevent App Store rejection when Apple login is not implemented.
Replace Capacitor.getPlatform() with Platform.is() getter methods in login/signup pages for better Ionic framework alignment and proper encapsulation. Add platform detection guidelines to documentation.
There was a problem hiding this comment.
Pull Request Overview
This PR hides the Google login button on iOS platforms to prevent App Store rejection when Apple login is not implemented. This addresses App Store guidelines that require apps offering third-party login options to also provide "Sign in with Apple" when available.
- Adds platform detection using Ionic's Platform service in both login and signup pages
- Conditionally hides Google login buttons on iOS using
*ngIf="!isIOS" - Updates development guidelines to standardize platform detection approach
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/features/signup/signup.page.ts | Adds Platform service injection and isIOS getter for platform detection |
| src/app/features/signup/signup.page.html | Conditionally hides Google login button on iOS |
| src/app/features/login/login.page.ts | Adds Platform service injection and isIOS getter for platform detection |
| src/app/features/login/login.page.html | Conditionally hides Google login button on iOS |
| CLAUDE.md | Documents platform detection best practice |
| .github/copilot-instructions.md | Documents platform detection best practice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide Google login button on iOS platforms in both login and signup pages to prevent App Store rejection when Apple login is not implemented.