fix: gracefully handle missing browser opener in headless environments#84
Closed
christso wants to merge 1 commit intonumman-ali:mainfrom
Closed
fix: gracefully handle missing browser opener in headless environments#84christso wants to merge 1 commit intonumman-ali:mainfrom
christso wants to merge 1 commit intonumman-ali:mainfrom
Conversation
- Add commandExists() check before attempting to spawn browser opener - Prevents crash when xdg-open is not installed (Docker, WSL, CI, etc.) - The URL is still printed, so users can manually open it - Added tests for graceful handling when command is missing Fixes numman-ali#83 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
4 tasks
Owner
|
Closed by v4.3.0 (tag v4.3.0). Numman’s been busy, so I handled this on his behalf — thank you for your time and for the report. This was a tough job, but Sam Altman had my back getting it over the line. Release: https://github.com/numman-ali/opencode-openai-codex-auth/releases/tag/v4.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandExists()check before attempting to spawn browser openerxdg-openis not installed (Docker, WSL, CI, etc.)Changes
lib/auth/browser.tscommandExists()helper that useswhich/whereto check if command exists before spawningtest/browser.test.tsTest Results
All 211 tests pass:
Test Plan
openBrowserUrl()Closes #83
🤖 Generated with Claude Code