parametrize tests#75
Merged
Merged
Conversation
Member
|
Looks good to me! I've run the test suite to see if there are any problems. There's one more improvement I think we can make. Notice how the values for numpy-financial/tests/test_financial.py Lines 102 to 119 in cd724f0 Thank you for taking the time to contribute |
Member
|
@tal66 this looks good now and tests are green. I don't think there's much more that needs to be done. Are you happy for me to merge it? |
Contributor
Author
|
sure |
Member
|
Merged :) Thanks again for taking the time to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, this closes #72.