feat: (ctl-api) skip auto-retries on terminal step errors#1104
Open
feat: (ctl-api) skip auto-retries on terminal step errors#1104
Conversation
onprem
force-pushed
the
ps/skip-auto-retries-when-no-builds
branch
from
6506b28 to
4dc02fd
Compare
ALPHAvibe
reviewed
Apr 30, 2026
| // succeed. Step-level auto-retry short-circuits on this marker | ||
| // (see signal.IsTerminalError). | ||
| return signal.NewTerminalError( | ||
| "component_build_errored", |
Contributor
There was a problem hiding this comment.
we should probably have a component build terminal error type for these
Contributor
Author
There was a problem hiding this comment.
So have one defined globally that we can reuse right? Will do.
onprem
force-pushed
the
ps/skip-auto-retries-when-no-builds
branch
from
7fa1844 to
83de0e3
Compare
Introduces a generic terminal-error mechanism so signals can mark a step failure as terminal — meaning retrying without external action cannot change the outcome (e.g., missing component build, build in error state). The conductor short-circuits auto-retry and surfaces a stable reason_code for the dashboard / CLI to render. Without this, a freshly-created install where a component had no successful build would burn the full auto-retry budget (3) on each sync/plan step before failing, even though the underlying condition will never resolve mid-run.
Signed-off-by: Prem Saraswat <prem@nuon.co>
onprem
force-pushed
the
ps/skip-auto-retries-when-no-builds
branch
from
83de0e3 to
c36e8e6
Compare
RealHarshThakur
approved these changes
Apr 30, 2026
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
|
This PR was marked as stale, and will be closed after 3 more days. Add the #keep-open label to prevent this from being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a generic terminal-error mechanism so signals can mark a step failure as terminal — meaning retrying without external action cannot change the outcome (e.g., missing component build, build in error state). The conductor short-circuits auto-retry and surfaces a stable reason_code for the dashboard / CLI to render.
Without this, a freshly-created install where a component had no successful build would burn the full auto-retry budget (3) on each sync/plan step before failing, even though the underlying condition will never resolve mid-run.
the step in not auto-retried.