Fix 'Create LogFile' option is on, but the option is not working when program is running.#147
Merged
gbakeman merged 2 commits intonutdotnet:dev-2.3from Apr 24, 2024
Merged
Conversation
Fix 'Create LogFile' option is on, but the option is not working when program is running.
Logger.vb: - Log file writing can be enabled or disabled by changing the `IsWritingToFile` property, or by calling the `Initialize`, `Delete` or `Terminate` subroutines. - Introduced new `TerminateLogFile` subroutine that gracefully closes a log file with a terminating line, without deleting the whole file. `DeleteLogFile` will terminate and delete the file. - Removed `TEST_RELEASE_DIRS` compiler directive so debug builds send log files to the executable. WinNUT.vb: - Renamed `WinNUT_PrefsChanged` subroutine to ApplyApplicationPreferences - Logger object configuration is now updated in that subroutine - logging configuration does not need to be modified from anywhere else in the code. - Centralized gauge initialization code into one place, removed from form load code. - Additional Pref Gui tweaks to how logging controls are handled, for better consistency. - Modified tooltip to be more concise. - Updated project-wide translations to match entries that need translating.
Contributor
|
I went and took the liberty to make a few other tweaks I had been wanting to make to how logging works - thank you for making this contribution! If you have the time, please also consider contributing to our translations - I know there have been a few changes lately that need translating. |
gbakeman
added a commit
that referenced
this pull request
Apr 27, 2024
Fix 'Create LogFile' option is on, but the option is not working when program is running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.Fix LogFile controls are disabled when the Create LogFile option is on.
#142
2.Fix 'Create LogFile' option is on, but the option is not working when program is running.