Power value calculation updates (specifically for Huawei UPS)#151
Merged
Power value calculation updates (specifically for Huawei UPS)#151
Conversation
- Added output current as new `UPS_Value` - Renamed a few `PowerMethod` enums to be more descriptive of what they do - Trying a new well-known variable initialization method that utilizes nullable values. Variable is left null if there's a problem retrieving it from the NUT server, then it will not be updated in the future. Only applying this to `output.current` since its use is limited to power calculation only. Applying this to other variables will likely require greater structural changes throughout WinNUT. - Added power calculation method involving output voltage and current, doable in a Huawei UPS (see #150) - GetUPSVar no longer prints a line assuming that the raised exception will go unhandled if a fallback value was not provided.
- Adding the `RealOutputPower` calculation method for UPS power output, specifically for Huawei UPSes. - Corrected mistake in `InputNomVALoadPct` calculation method that omitted a multiplication - Make error more clear if execution ever reaches Else case in power calculation switch statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPS_ValuePowerMethodenums to be more descriptive of what they dooutput.currentsince its use is limited to power calculation only. Applying this to other variables will likely require greater structural changes throughout WinNUT.GetUPSVarno longer prints a line assuming that the raised exception will go unhandled if a fallback value was not provided.output.realpowerUPS variable (also related to above issue)InputNomVALoadPctCloses #150