Persistent Connection attempts, quieter notifications#171
Merged
Conversation
- Add IsUPSConnected property to main WinNUT form for easier connection state checking - Removed unused AutoReconnect boolean - Added SettingsPropertyChanged method to activate when a setting is changed, allowing the UI to update any relevant states. - Added UpdateMainMenuState which allows the main menu's state to be updated conveniently and consistently from anywhere in the WinNUT UI code (replaces the UpdateManageOldPrefsMenuItemStatus subroutine.) - Reorganized the Connection menu, renaming the (Re)connect command, and adding a Persist toggle that controls the auto reconnection feature. Adding some graphics, and better control over the menu item's enabled state. - Visual Studio designer deciding to move designer code around for no apparent reason
The main window title of WinNUT occasionally deviated from the defined program name (WinNUT Client) to just WinNUT. The string has been replaced.
UPS_Device.vb - Provide a public readonly property indicating if the reconnect Timer is operating or not. - Remove retry connection attempt event, retry counter and max retries integer. - Connect_UPS subroutine only starts the reconnection timer on error if it isn't running already. - General exception in Retrieve_UPS_Datas no longer calls the disconnect subroutine, in favor of the Socket_Broken sub (prevents double notifications to listening code.) - Removed several strings related to reconnection attempts - Do not announce connection errors while attempting to reconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65, also may impact #145.