Conversation
Relocating the Event_ChangeStatus method to be closer to other NotifyIcon-related code.
- Sub made private, unshared and removed static references to instance members - Added logging for troubleshooting
- Relocated the Login() call back into the UPS class to keep logic and exceptions out of the WinNUT form (fixes connected notifications not appearing on reconnect) - Properly unset logged in flag when disconnecting. From my limited testing, the NUT server does not care how you disconnect from it - you'll always be able to log back in.
gbakeman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login()call back into the UPS class to remove control logic out of the main WinNUT form and prevent exceptions from being thrown inside an event handlerCloses
Related to
LOGINcommand #106