refactor: simplify domain utility functions

[BobbieGoede]

🔗 Linked issue

📚 Description

Summary by CodeRabbit

• Refactor
  • Improved how host and protocol information are retrieved and handled, resulting in more consistent and flexible domain and locale management across the application. No changes to user-facing features or behavior.

[coderabbitai]

Walkthrough

The changes refactor how host and protocol information are retrieved in domain-related functions, centralizing this logic through useRequestURL. Function signatures are updated to accept optional host parameters, and the invocation of createDomainFromLocaleGetter is modified to no longer require a Nuxt app context.

Changes

File(s)	Change Summary
src/runtime/context.ts	Updated createNuxtI18nContext to call createDomainFromLocaleGetter without arguments.
src/runtime/domain.ts	Unified protocol/host retrieval via useRequestURL, removed unused imports, updated function signatures to accept optional host parameters, and refactored domain getter creation logic.

Sequence Diagram(s)

sequenceDiagram
    participant Context as createNuxtI18nContext
    participant Domain as createDomainFromLocaleGetter
    participant URL as useRequestURL

    Context->>Domain: createDomainFromLocaleGetter()
    Domain->>URL: useRequestURL({ xForwardedHost: true })
    URL-->>Domain: { protocol, host }
    Domain-->>Context: getDomainFromLocale (function)

Loading

Possibly related PRs

• refactor: rework internal nuxt i18n context #3612: Refactors the internal Nuxt i18n context, including restructuring of createNuxtI18nContext and domain-related logic, which is directly connected to the changes in this PR.

Poem

A hop and a skip, the domains align,
With useRequestURL, the host is now fine.
No more Nuxt context passed around,
Just clean little functions, tidy and sound.
🐇✨ The code is now neat—
Refactoring complete!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2efcd31 and df57a31.

📒 Files selected for processing (2)

• src/runtime/context.ts (1 hunks)
• src/runtime/domain.ts (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/runtime/context.ts (1)

src/runtime/domain.ts (1)

• createDomainFromLocaleGetter (54-73)

src/runtime/domain.ts (2)

src/types.ts (1)

• LocaleObject (288-306)

src/runtime/kit/types.ts (1)

• Locale (2-2)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test (lts/*, ubuntu-latest)
• GitHub Check: test (lts/*, windows-latest)

🔇 Additional comments (7)

src/runtime/domain.ts (6)

2-2: LGTM! Clean import simplification.

The import consolidation from getRequestProtocol, getRequestHost, and useRequestEvent to just useRequestURL aligns well with the refactoring goal of centralizing request URL handling.

---

15-17: LGTM! Simplified host retrieval.

The getHost function is now consistently using useRequestURL({ xForwardedHost: true }).host, which properly handles proxy/load balancer scenarios and eliminates the need for conditional server/client logic.

---

26-26: LGTM! Good addition of optional parameter.

Adding the optional host parameter with a default value of getHost() maintains backward compatibility while providing flexibility for testing and custom scenarios.

---

54-54: LGTM! Consistent parameter pattern.

The addition of the optional host parameter with default value follows the same pattern as other functions in this refactoring, providing consistency across the codebase.

---

71-71: LGTM! Centralized protocol handling.

Using useRequestURL().protocol directly instead of a separate getProtocol function simplifies the code and aligns with the centralized approach of this refactoring.

---

101-101: LGTM! Consistent optional parameter addition.

The optional host parameter maintains the consistent pattern established in this refactoring while preserving backward compatibility.

src/runtime/context.ts (1)

79-79: LGTM! Properly aligned with domain.ts changes.

The removal of the argument to createDomainFromLocaleGetter() correctly reflects the updated function signature in src/runtime/domain.ts where the host parameter now defaults to getHost(). This change maintains functionality while simplifying the call site.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.