fix: ignore capacitor paths if present#770
Merged
danielroe merged 8 commits intonuxt-modules:mainfrom Jul 30, 2025
Merged
Conversation
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
==========================================
- Coverage 46.72% 46.17% -0.56%
==========================================
Files 11 12 +1
Lines 672 732 +60
Branches 34 47 +13
==========================================
+ Hits 314 338 +24
- Misses 358 394 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
i could also add the functionality from #469 as it seems it was never completed? @danielroe |
Collaborator
|
@NRodriguezcuellar that would be a really nice idea - maybe useful for a future PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #647
❓ Type of change
📚 Description
These changes add deeper integration to capacitor enabled projects, initial setup is done to adjust the typescript config according to if a capacitor config file is present and the path that it has set, so it can be excluded for type checking