Conversation
Bundle Stats — create-nuxt size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — nuxt-cli size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — nuxi size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
commit: |
CodSpeed Performance ReportMerging #1043 will not alter performanceComparing Summary
|
danielroe
left a comment
There was a problem hiding this comment.
I think for non-nuxt projects we should directly use the giget CLI.
needing to support them in nuxt/cli itself will add a bit too much complexity to maintaining it, I think.
|
This is what I thought but wanted to confirm with you. It's just that the DX of nuxt init is sexy (confirm to overwrite if dir exists, ask to install deps, etc) Will revert some changes |
We could add this features to giget CLI too btw. |
Sounds good, I guess we will need to support passing the package manager here |
await import()was wrong, fixed it by usingreadPackageJSON