fix(dev): respect https.xxx commandline arguments#1129
Conversation
commit: |
📦 Bundle Size Comparison📉 nuxi
📉 nuxt-cli
📉 create-nuxt
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage ? 24.56%
=======================================
Files ? 87
Lines ? 4588
Branches ? 245
=======================================
Hits ? 1127
Misses ? 3430
Partials ? 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1129 will not alter performanceComparing Summary
|
| description: 'Host to listen on (default: `NUXT_HOST || NITRO_HOST || HOST || nuxtOptions.devServer?.host`)', | ||
| }, | ||
| 'clipboard': { ...listhenArgs.clipboard, default: false }, | ||
| 'https.domains': { |
There was a problem hiding this comment.
removed https.domains as it was identical to the original option's definition
listhen/cli.ts
|
would be nice to handle a couple of other cases in the tests/fix. there are a couple of other reports, like this one in discord:
NUXT_HOST=dev.com
NUXT_PORT=3000
NITRO_SSL_CERT=./dev.com.pem
NITRO_SSL_KEY=./dev.com.pemnuxt dev --https |
06a7af1 to
a361eae
Compare
|
thank you for your advice.
i'd appreciate your review. |
a361eae to
4d201b2
Compare
4d201b2 to
d963b66
Compare
🔗 Linked issue
❓ Type of change
📚 Description
I noticed that specifying command-line options like https.cert and https.key wasn't taking effect, so I implemented a fix.