Skip to content

fix(init): ask before showing modules selector#895

Merged
danielroe merged 4 commits intonuxt:mainfrom
cernymatej:fix-ask-before-picking-modules
Jun 10, 2025
Merged

fix(init): ask before showing modules selector#895
danielroe merged 4 commits intonuxt:mainfrom
cernymatej:fix-ask-before-picking-modules

Conversation

@cernymatej
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This makes it more clear to users how to skip the module selection. The previous implementation didn't explicitly display a way to do it.


I'm wondering if it would be a good idea to show tips about CLI arguments when the user selects an option for the first time. Something like:

✔ Initialize git repository?
No

-----------------------------------------------------------
TIP: You can use `--git-init=0` to skip git initialization.
-----------------------------------------------------------

(of course it should only appear for the first time and be styled nicely)

@cernymatej cernymatej requested a review from danielroe as a code owner June 2, 2025 22:24
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-nuxt@895
npm i https://pkg.pr.new/nuxi@895
npm i https://pkg.pr.new/@nuxt/cli@895

commit: 8a85c4b

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@96999d6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/init.ts 0.00% 26 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #895   +/-   ##
=======================================
  Coverage        ?   12.95%           
=======================================
  Files           ?       69           
  Lines           ?     3597           
  Branches        ?      100           
=======================================
  Hits            ?      466           
  Misses          ?     3100           
  Partials        ?       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cernymatej
Copy link
Member Author

there are probably some permission issues in the size comparison check

Co-authored-by: Damian Głowala <damian.glowala.rebkow@gmail.com>
@danielroe danielroe merged commit fe091bf into nuxt:main Jun 10, 2025
8 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants