fix(init): ask before showing modules selector#895
Merged
Conversation
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
=======================================
Coverage ? 12.95%
=======================================
Files ? 69
Lines ? 3597
Branches ? 100
=======================================
Hits ? 466
Misses ? 3100
Partials ? 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
there are probably some permission issues in the size comparison check |
DamianGlowala
requested changes
Jun 4, 2025
Co-authored-by: Damian Głowala <damian.glowala.rebkow@gmail.com>
danielroe
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This makes it more clear to users how to skip the module selection. The previous implementation didn't explicitly display a way to do it.
I'm wondering if it would be a good idea to show tips about CLI arguments when the user selects an option for the first time. Something like:
(of course it should only appear for the first time and be styled nicely)