test: close servers by danielroe · Pull Request #904 · nuxt/cli

danielroe · 2025-06-06T16:20:17Z

🔗 Linked issue

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

avoids benchmark running out of memory + getting garbled results

pkg-pr-new · 2025-06-06T16:22:24Z

npm i https://pkg.pr.new/create-nuxt@904

npm i https://pkg.pr.new/nuxi@904

npm i https://pkg.pr.new/@nuxt/cli@904

commit: c07c7ef

github-actions · 2025-06-06T16:22:37Z

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
49	5.94 MB → 5.94 MB (+317 B)	+0.01%

Changeset

File	Δ	Size
`home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts`	📈 +271 B (+2.81%)	9.41 kB → 9.67 kB
`home/runner/work/cli/cli/packages/nuxi/src/utils/dev.ts`	📈 +46 B (+0.54%)	8.36 kB → 8.4 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
chunks/dev.mjs	9.41 kB → 9.67 kB (+271 B)	+2.81%
chunks/dev2.mjs	252.09 kB → 252.14 kB (+46 B)	+0.02%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	1.07 kB	0%
chunks/multipart-parser.mjs	5.11 kB	0%
chunks/multipart-parser2.mjs	4.58 kB	0%
chunks/add.mjs	6.89 kB	0%
chunks/analyze.mjs	3.27 kB	0%
chunks/build.mjs	1.97 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	2.33 kB	0%
chunks/devtools.mjs	764 B	0%
chunks/generate.mjs	472 B	0%
chunks/info.mjs	4.39 kB	0%
chunks/index.mjs	274 B	0%
chunks/prepare.mjs	984 B	0%
chunks/preview.mjs	3.5 kB	0%
chunks/test.mjs	1.16 kB	0%
chunks/typecheck.mjs	1.81 kB	0%
chunks/upgrade.mjs	6.28 kB	0%
chunks/prompt.mjs	42.91 kB	0%
chunks/satisfies.mjs	116 B	0%
chunks/kit.mjs	1.34 kB	0%
chunks/index2.mjs	1.17 MB	0%
chunks/index3.mjs	17.14 kB	0%
chunks/index4.mjs	71.99 kB	0%
chunks/add2.mjs	12.4 kB	0%
chunks/search.mjs	45.85 kB	0%
chunks/xdg-open.mjs	25.32 kB	0%
chunks/node.mjs	145.67 kB	0%
chunks/index5.mjs	1.23 kB	0%
chunks/index6.mjs	6.25 kB	0%
chunks/index7.mjs	50.54 kB	0%
chunks/index8.mjs	5.85 kB	0%
chunks/index9.mjs	898.9 kB	0%
shared/create-nuxt.KRfcAabz.mjs	961.96 kB	0%
shared/create-nuxt.C9PGmh_y.mjs	18.91 kB	0%
shared/create-nuxt.C__7_gXu.mjs	804 B	0%
shared/create-nuxt.CHZLvr-7.mjs	294 B	0%
shared/create-nuxt.DCTmUpvU.mjs	3.9 kB	0%
shared/create-nuxt.BloYjiZ4.mjs	4.07 kB	0%
shared/create-nuxt.BSm0_9Hr.mjs	107 B	0%
shared/create-nuxt.Dn0TYcSC.mjs	836 B	0%
shared/create-nuxt.GYyp52oB.mjs	108.13 kB	0%
shared/create-nuxt.4t9faemh.mjs	43.64 kB	0%
shared/create-nuxt.1BTwlbMH.mjs	2.02 MB	0%
shared/create-nuxt.BjhZEm2-.mjs	1.75 kB	0%
shared/create-nuxt.Vk1IrVtB.mjs	26.96 kB	0%
shared/create-nuxt.Dh7YQg9j.mjs	15.27 kB	0%
shared/create-nuxt.CHDOs5mq.mjs	715 B	0%

github-actions · 2025-06-06T16:22:46Z

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
55	5.51 MB → 5.51 MB (+317 B)	+0.01%

Changeset

File	Δ	Size
`src/commands/dev.ts`	📈 +271 B (+2.81%)	9.41 kB → 9.67 kB
`src/utils/dev.ts`	📈 +46 B (+0.54%)	8.36 kB → 8.4 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
chunks/dev.mjs	9.41 kB → 9.67 kB (+271 B)	+2.81%
chunks/dev2.mjs	252.1 kB → 252.14 kB (+46 B)	+0.02%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	210 B	0%
chunks/prompt.mjs	42.91 kB	0%
chunks/add.mjs	6.89 kB	0%
chunks/analyze.mjs	3.27 kB	0%
chunks/build.mjs	1.97 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	2.33 kB	0%
chunks/devtools.mjs	764 B	0%
chunks/generate.mjs	472 B	0%
chunks/info.mjs	4.39 kB	0%
chunks/init.mjs	664.23 kB	0%
chunks/index.mjs	274 B	0%
chunks/prepare.mjs	984 B	0%
chunks/preview.mjs	3.5 kB	0%
chunks/test.mjs	1.16 kB	0%
chunks/typecheck.mjs	1.81 kB	0%
chunks/upgrade.mjs	6.28 kB	0%
chunks/satisfies.mjs	116 B	0%
chunks/main.mjs	15.3 kB	0%
chunks/index2.mjs	915.2 kB	0%
chunks/index3.mjs	17.14 kB	0%
chunks/index4.mjs	71.99 kB	0%
chunks/multipart-parser.mjs	5.11 kB	0%
chunks/add2.mjs	12.4 kB	0%
chunks/search.mjs	45.85 kB	0%
chunks/xdg-open.mjs	25.32 kB	0%
chunks/node.mjs	145.67 kB	0%
chunks/index5.mjs	1.23 kB	0%
chunks/index6.mjs	5.85 kB	0%
chunks/multipart-parser2.mjs	4.58 kB	0%
chunks/index7.mjs	898.9 kB	0%
shared/nuxi.CkbmDTVf.mjs	76.37 kB	0%
shared/nuxi.CTyTlDmo.mjs	18.91 kB	0%
shared/nuxi.Dj-nnhaV.mjs	804 B	0%
shared/nuxi.CU8S2ItD.mjs	294 B	0%
shared/nuxi.DCZEnUMf.mjs	2.57 kB	0%
shared/nuxi.D2_bzAv0.mjs	1.54 kB	0%
shared/nuxi.DEraSSNZ.mjs	4.07 kB	0%
shared/nuxi.BSm0_9Hr.mjs	107 B	0%
shared/nuxi.4mU2hXBN.mjs	836 B	0%
shared/nuxi.BxIDvNqq.mjs	1.34 kB	0%
shared/nuxi.CzTDygJD.mjs	15.27 kB	0%
shared/nuxi.DGlTnfJO.mjs	25.34 kB	0%
shared/nuxi.C4l48OVX.mjs	2.02 MB	0%
shared/nuxi.D5KtpA0t.mjs	984 B	0%
shared/nuxi.BjhZEm2-.mjs	1.75 kB	0%
shared/nuxi.BfF9qfft.mjs	715 B	0%
shared/nuxi.DU9QXUOf.mjs	26.96 kB	0%
shared/nuxi.BzZJv2UC.mjs	123.67 kB	0%
shared/nuxi.QWnQy_ku.mjs	5.75 kB	0%
shared/nuxi.CDtHTpB4.mjs	55.13 kB	0%
shared/nuxi.Do0aYBCO.mjs	5.46 kB	0%
shared/nuxi.4t9faemh.mjs	43.64 kB	0%

github-actions · 2025-06-06T16:22:55Z

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
30	86.48 kB → 86.79 kB (+317 B)	+0.36%

Changeset

File	Δ	Size
`home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts`	📈 +271 B (+2.83%)	9.36 kB → 9.63 kB
`home/runner/work/cli/cli/packages/nuxi/src/utils/dev.ts`	📈 +46 B (+0.54%)	8.35 kB → 8.4 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
chunks/dev.mjs	9.36 kB → 9.63 kB (+271 B)	+2.83%
chunks/dev2.mjs	8.65 kB → 8.7 kB (+46 B)	+0.52%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	200 B	0%
chunks/add.mjs	6.89 kB	0%
chunks/analyze.mjs	3.27 kB	0%
chunks/build.mjs	1.97 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	2.33 kB	0%
chunks/devtools.mjs	763 B	0%
chunks/generate.mjs	472 B	0%
chunks/info.mjs	4.39 kB	0%
chunks/init.mjs	8.1 kB	0%
chunks/index.mjs	274 B	0%
chunks/prepare.mjs	984 B	0%
chunks/preview.mjs	3.5 kB	0%
chunks/test.mjs	1.16 kB	0%
chunks/typecheck.mjs	1.81 kB	0%
chunks/upgrade.mjs	6.28 kB	0%
chunks/add2.mjs	10.48 kB	0%
chunks/search.mjs	2.96 kB	0%
shared/cli.CyjRwZnH.mjs	5.45 kB	0%
shared/cli.CVvsnRpF.mjs	804 B	0%
shared/cli.wjLTNSBo.mjs	294 B	0%
shared/cli.CFGy0wx0.mjs	1.23 kB	0%
shared/cli.BSm0_9Hr.mjs	107 B	0%
shared/cli.BI-F07wL.mjs	836 B	0%
shared/cli.DlcAx0De.mjs	1.04 kB	0%
shared/cli.CkLtVfMJ.mjs	1.78 kB	0%
shared/cli.P0cplz3M.mjs	78 B	0%
shared/cli.C935N1ss.mjs	687 B	0%

codspeed-hq · 2025-06-06T16:28:44Z

CodSpeed Performance Report

Merging #904 will improve performances by 13.11%

_{Comparing test/close (c07c7ef) with main (de8cd3a)}

Summary

⚡ 1 improvements
🆕 1 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`makes requests to dev server`	99.9 ms	88.4 ms	+13.11%
⁉️	`starts dev server`	568.4 ms	N/A	N/A
⁉️	`starts dev server in no-fork mode`	1.3 s	N/A	N/A
🆕	`starts dev server with --no-fork`	N/A	925.7 ms	N/A

danielroe and others added 2 commits June 6, 2025 17:18

test: close servers

bdb54b2

[autofix.ci] apply automated fixes

bc6f1bd

danielroe added 23 commits June 7, 2025 10:11

test: try using beforeEach/afterAll to clean up

6955486

test: don't use beforeAll

4b29ddb

test: close within bench

4063783

test: only test --fork

8193546

ci: use codspeed runner

4588b51

ci: node 18

ccdec0c

test: only run with --no-fork

adef6b4

fix: swap order in close

9392695

chore: drop afterAll

8076e73

ci: run on ubuntu

a1846d4

ci: allow manual trigger

17efe42

test: test built nuxi

cb102ab

ci: from package name

ee8196a

ci: build before typecheck

987b88a

ci: back to github runner

c88646f

chore: remove

ebbba27

chore: remove modules

f03d8d1

chore: remove modules

25b3cbd

test: refactor start script

20b0e5b

ci: prepare playground

84dcf25

test: also test fork 🤞

f7d9983

test: split out again

0824329

test: only no-fork

8c20c22

test: non-async describe

c07c7ef

danielroe merged commit 59f83b1 into main Jun 7, 2025
14 checks passed

danielroe deleted the test/close branch June 7, 2025 21:01

github-actions bot mentioned this pull request Jun 7, 2025

v3.26.0 #900

Merged

Eazash mentioned this pull request Sep 17, 2025

perf(create-nuxt): refactor for improved tree-shaking #1044

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: close servers#904

test: close servers#904
danielroe merged 26 commits intomainfrom
test/close

danielroe commented Jun 6, 2025

Uh oh!

pkg-pr-new bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

danielroe commented Jun 6, 2025

🔗 Linked issue

❓ Type of change

📚 Description

Uh oh!

pkg-pr-new bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — create-nuxt size comparison

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — nuxi size comparison

Uh oh!

github-actions bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Stats — nuxt-cli size comparison

Uh oh!

codspeed-hq bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #904 will improve performances by 13.11%

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

pkg-pr-new bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

github-actions bot commented Jun 6, 2025 •

edited

Loading

codspeed-hq bot commented Jun 6, 2025 •

edited

Loading