Skip to content

fix: prioritise @nuxt/kit from nuxt dependencies#929

Merged
danielroe merged 1 commit intomainfrom
fix/kit-version
Jun 27, 2025
Merged

fix: prioritise @nuxt/kit from nuxt dependencies#929
danielroe merged 1 commit intomainfrom
fix/kit-version

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

currently we might pick an older version of nuxt/kit if a module has installed it and it's available locally.

this ensures we prefer the version of kit matching nuxt. (newer versions of kit, if installed, might be deduplicated by package manager but should 'flow down', so this is safer - and should also be more performant)

@github-actions
Copy link
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
49 5.88 MB → 5.88 MB (-135 B) -0.00%
Changeset
File Δ Size
home/runner/work/cli/cli/packages/nuxi/src/utils/kit.ts 📉 -135 B (-12.50%) 1.05 kB → 945 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/create-nuxt.C4mQdlco.mjs 0 B → 945 B (+945 B) -
shared/create-nuxt.CLkBPnlR.mjs 0 B → 792 B (+792 B) -

Removed

Asset File Size % Changed
shared/create-nuxt.0VtSoDeL.mjs 1.05 kB → 0 B (-1.05 kB) -100%
shared/create-nuxt.GQ4ySyuL.mjs 792 B → 0 B (-792 B) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/build.mjs 1.96 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 811 B 0%
chunks/dev.mjs 27.24 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 472 B 0%
chunks/info.mjs 4.38 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.78 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/index2.mjs 194.26 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/index6.mjs 6.24 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 898.9 kB 0%
shared/create-nuxt.B71Ptx3t.mjs 963.78 kB 0%
shared/create-nuxt.BzVnAJ6D.mjs 294 B 0%
shared/create-nuxt.BZEC9aF-.mjs 3.9 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.BHNcDoGS.mjs 108.11 kB 0%
shared/create-nuxt.DWN1j4sa.mjs 18.91 kB 0%
shared/create-nuxt.DzJUR39Z.mjs 1.17 MB 0%
shared/create-nuxt.DgkXlNAq.mjs 4.07 kB 0%
shared/create-nuxt.DrUPYlIo.mjs 836 B 0%
shared/create-nuxt.BGYNhO8g.mjs 15.27 kB 0%
shared/create-nuxt.Be-Kjlkt.mjs 2.02 MB 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.CNhf76gk.mjs 4.06 kB 0%
shared/create-nuxt.Vk1IrVtB.mjs 26.96 kB 0%
shared/create-nuxt.4t9faemh.mjs 43.64 kB 0%

@github-actions
Copy link
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
32 90.29 kB → 90.16 kB (-135 B) -0.15%
Changeset
File Δ Size
home/runner/work/cli/cli/packages/nuxi/src/utils/kit.ts 📉 -135 B (-12.50%) 1.05 kB → 945 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/cli.qKvs7FJ2.mjs 0 B → 945 B (+945 B) -
shared/cli.Dz2be-Ai.mjs 0 B → 792 B (+792 B) -

Removed

Asset File Size % Changed
shared/cli.BrKZotr9.mjs 1.05 kB → 0 B (-1.05 kB) -100%
shared/cli.Dvb-m6bf.mjs 792 B → 0 B (-792 B) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
dev/index.mjs 0 B 0%
index.mjs 236 B 0%
chunks/index.mjs 11.43 kB 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 815 B 0%
chunks/dev.mjs 10.09 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 472 B 0%
chunks/build.mjs 1.96 kB 0%
chunks/info.mjs 4.39 kB 0%
chunks/index2.mjs 273 B 0%
chunks/add.mjs 10.17 kB 0%
chunks/search.mjs 2.96 kB 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.78 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/init.mjs 9.85 kB 0%
chunks/add2.mjs 6.89 kB 0%
shared/cli.B9AmABr3.mjs 39 B 0%
shared/cli.BEUGgaW4.mjs 294 B 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.At9IMXtr.mjs 1.23 kB 0%
shared/cli.pLQ0oPGc.mjs 836 B 0%
shared/cli.P0cplz3M.mjs 78 B 0%
shared/cli.jA1DRKbi.mjs 1.04 kB 0%
shared/cli.BLVI_04J.mjs 1.8 kB 0%
shared/cli.yHMpVeHl.mjs 5.42 kB 0%

@github-actions
Copy link
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
58 5.46 MB → 5.46 MB (-135 B) -0.00%
Changeset
File Δ Size
src/utils/kit.ts 📉 -135 B (-12.50%) 1.05 kB → 945 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.BiWTNJI4.mjs 0 B → 945 B (+945 B) -
shared/nuxi.DzMZtGWH.mjs 0 B → 792 B (+792 B) -

Removed

Asset File Size % Changed
shared/nuxi.dlymdmbV.mjs 1.05 kB → 0 B (-1.05 kB) -100%
shared/nuxi.DKSCJgDw.mjs 792 B → 0 B (-792 B) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 247 B 0%
dev/index.mjs 896 B 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.27 kB 0%
chunks/build.mjs 1.96 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 780 B 0%
chunks/dev.mjs 27.24 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 472 B 0%
chunks/info.mjs 4.38 kB 0%
chunks/init.mjs 665.88 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 3.5 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.78 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index2.mjs 194.26 kB 0%
chunks/index3.mjs 71.97 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/index6.mjs 898.9 kB 0%
shared/nuxi.DFIyyeua.mjs 19.18 kB 0%
shared/nuxi.Dh2ZdpAd.mjs 57.22 kB 0%
shared/nuxi.CTyTlDmo.mjs 18.91 kB 0%
shared/nuxi.BtDT0y5R.mjs 294 B 0%
shared/nuxi.Cm5apyPX.mjs 2.57 kB 0%
shared/nuxi.Db0skjkt.mjs 915.23 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.DtQ0anGB.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DMyZmNH9.mjs 836 B 0%
shared/nuxi.BMIgfYLN.mjs 15.26 kB 0%
shared/nuxi.DRfkfsvA.mjs 25.34 kB 0%
shared/nuxi.D5KtpA0t.mjs 984 B 0%
shared/nuxi.wc1-AWrO.mjs 2.02 MB 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.pQKP70qC.mjs 4.06 kB 0%
shared/nuxi.DU9QXUOf.mjs 26.96 kB 0%
shared/nuxi.BzZJv2UC.mjs 123.67 kB 0%
shared/nuxi.QWnQy_ku.mjs 5.75 kB 0%
shared/nuxi.CvGKll9s.mjs 12.8 kB 0%
shared/nuxi.BLb4POFS.mjs 42.47 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.4t9faemh.mjs 43.64 kB 0%

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 27, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@929
npm i https://pkg.pr.new/nuxi@929
npm i https://pkg.pr.new/@nuxt/cli@929

commit: cfa2ccb

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 27, 2025

CodSpeed Performance Report

Merging #929 will not alter performance

Comparing fix/kit-version (cfa2ccb) with main (e5ef49e)

Summary

✅ 2 untouched benchmarks

@danielroe danielroe merged commit 810220d into main Jun 27, 2025
14 checks passed
@danielroe danielroe deleted the fix/kit-version branch June 27, 2025 12:28
@github-actions github-actions bot mentioned this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant