Skip to content

fix(dev): process.title could potentially be undefined#946

Merged
danielroe merged 2 commits intonuxt:mainfrom
akfakf0509:fix/process-title
Jul 8, 2025
Merged

fix(dev): process.title could potentially be undefined#946
danielroe merged 2 commits intonuxt:mainfrom
akfakf0509:fix/process-title

Conversation

@akfakf0509
Copy link
Contributor

🔗 Linked issue

resolves #945

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolved a failure in the dev script caused by process.title being undefined in certain environments (such as StackBlitz).

@akfakf0509 akfakf0509 requested a review from danielroe as a code owner July 8, 2025 07:09
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 8, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@946
npm i https://pkg.pr.new/nuxi@946
npm i https://pkg.pr.new/@nuxt/cli@946

commit: 52dfe84

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@a85c4b7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/dev/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage        ?   12.51%           
=======================================
  Files           ?       74           
  Lines           ?     3900           
  Branches        ?      112           
=======================================
  Hits            ?      488           
  Misses          ?     3378           
  Partials        ?       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #946 will not alter performance

Comparing akfakf0509:fix/process-title (52dfe84) with main (a85c4b7)

Summary

✅ 2 untouched benchmarks

@akfakf0509 akfakf0509 requested a review from OrbisK July 8, 2025 08:10
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! ❤️

@danielroe danielroe merged commit 048ad16 into nuxt:main Jul 8, 2025
11 of 14 checks passed
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
@akfakf0509 akfakf0509 deleted the fix/process-title branch July 18, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process.title could potentially be undefined.

4 participants