Skip to content

refactor(dev): use get-port-please to produce socket addresses#952

Merged
danielroe merged 3 commits intomainfrom
refactor/socket-path
Jul 11, 2025
Merged

refactor(dev): use get-port-please to produce socket addresses#952
danielroe merged 3 commits intomainfrom
refactor/socket-path

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

we extracted socket path utils into get-port-please.

linked: nitrojs/nitro@4f27523, unjs/get-port-please#110

@danielroe danielroe self-assigned this Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
58 5.47 MB → 5.47 MB (+1.02 kB) +0.02%
Changeset
File Δ Size
node_modules/get-port-please/dist/index.mjs 📈 +1.47 kB (+21.54%) 6.82 kB → 8.29 kB
src/commands/dev.ts 📈 +7 B (+0.06%) 11.08 kB → 11.08 kB
src/dev/socket.ts 📉 -464 B (-22.86%) 1.98 kB → 1.53 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.Cit_PhVF.mjs 0 B → 916.43 kB (+916.43 kB) -
shared/nuxi.D7O6R7TO.mjs 0 B → 2.57 kB (+2.57 kB) -

Removed

Asset File Size % Changed
shared/nuxi.mckSyPJc.mjs 914.96 kB → 0 B (-914.96 kB) -100%
shared/nuxi.B9b6BodX.mjs 2.57 kB → 0 B (-2.57 kB) -100%

Bigger

Asset File Size % Changed
chunks/dev.mjs 28.21 kB → 28.22 kB (+7 B) +0.02%

Smaller

Asset File Size % Changed
chunks/index2.mjs 197.8 kB → 197.35 kB (-464 B) -0.23%

Unchanged

Asset File Size % Changed
index.mjs 247 B 0%
dev/index.mjs 925 B 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/build.mjs 2.04 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 780 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 492 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/init.mjs 665.87 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 2.06 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/index6.mjs 900.74 kB 0%
shared/nuxi.bYOTTMda.mjs 19.31 kB 0%
shared/nuxi.Dh2ZdpAd.mjs 57.22 kB 0%
shared/nuxi.CTyTlDmo.mjs 18.91 kB 0%
shared/nuxi.DzMZtGWH.mjs 792 B 0%
shared/nuxi.BtDT0y5R.mjs 294 B 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.DtQ0anGB.mjs 4.07 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DMyZmNH9.mjs 836 B 0%
shared/nuxi.BiWTNJI4.mjs 945 B 0%
shared/nuxi.BVCmUwv2.mjs 15.27 kB 0%
shared/nuxi.ChutbOY_.mjs 25.34 kB 0%
shared/nuxi.BAGoDD49.mjs 1.05 kB 0%
shared/nuxi.B5t53vrk.mjs 2.02 MB 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.BEgIcxrx.mjs 4.06 kB 0%
shared/nuxi.DU9QXUOf.mjs 26.96 kB 0%
shared/nuxi.BzZJv2UC.mjs 123.67 kB 0%
shared/nuxi.QWnQy_ku.mjs 5.75 kB 0%
shared/nuxi.CbyJ5osS.mjs 13.45 kB 0%
shared/nuxi.BLb4POFS.mjs 42.47 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.4t9faemh.mjs 43.64 kB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
32 95.31 kB → 94.86 kB (-458 B) -0.47%
Changeset
File Δ Size
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts 📉 -458 B (-22.65%) 1.97 kB → 1.53 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
chunks/index.mjs 14.79 kB → 14.35 kB (-458 B) -3.02%

Unchanged

Asset File Size % Changed
dev/index.mjs 0 B 0%
index.mjs 236 B 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 815 B 0%
chunks/dev.mjs 11.08 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 492 B 0%
chunks/build.mjs 2.04 kB 0%
chunks/info.mjs 4.44 kB 0%
chunks/index2.mjs 273 B 0%
chunks/add.mjs 10.17 kB 0%
chunks/search.mjs 2.96 kB 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 2.06 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/init.mjs 9.85 kB 0%
chunks/add2.mjs 6.89 kB 0%
shared/cli.B9AmABr3.mjs 39 B 0%
shared/cli.Dz2be-Ai.mjs 792 B 0%
shared/cli.BEUGgaW4.mjs 294 B 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.At9IMXtr.mjs 1.23 kB 0%
shared/cli.pLQ0oPGc.mjs 836 B 0%
shared/cli.qKvs7FJ2.mjs 945 B 0%
shared/cli.P0cplz3M.mjs 78 B 0%
shared/cli.jA1DRKbi.mjs 1.04 kB 0%
shared/cli.Cxye68Cs.mjs 1.8 kB 0%
shared/cli.BpQCmRC-.mjs 5.55 kB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
49 5.89 MB → 5.9 MB (+1.02 kB) +0.02%
Changeset
File Δ Size
node_modules/get-port-please/dist/index.mjs 📈 +1.47 kB (+21.54%) 6.82 kB → 8.29 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts 📈 +7 B (+0.06%) 11.08 kB → 11.08 kB
home/runner/work/cli/cli/packages/nuxi/src/dev/socket.ts 📉 -464 B (-22.86%) 1.98 kB → 1.53 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/create-nuxt.DHvyDQnB.mjs 0 B → 2.02 MB (+2.02 MB) -
shared/create-nuxt.BpAByT2l.mjs 0 B → 1.17 MB (+1.17 MB) -
shared/create-nuxt.xX0Cvyw9.mjs 0 B → 964.65 kB (+964.65 kB) -
shared/create-nuxt.gJC6FBVJ.mjs 0 B → 108.11 kB (+108.11 kB) -
shared/create-nuxt.DYj-zHwR.mjs 0 B → 18.91 kB (+18.91 kB) -
shared/create-nuxt.Cjt-aVEF.mjs 0 B → 15.27 kB (+15.27 kB) -
shared/create-nuxt.DXjQxQEj.mjs 0 B → 4.07 kB (+4.07 kB) -
shared/create-nuxt.FJxpc8RG.mjs 0 B → 4.06 kB (+4.06 kB) -
shared/create-nuxt.CpC6T01a.mjs 0 B → 3.9 kB (+3.9 kB) -
shared/create-nuxt.zlQdpBpk.mjs 0 B → 945 B (+945 B) -
shared/create-nuxt.C70uiq1n.mjs 0 B → 836 B (+836 B) -
shared/create-nuxt.Dl70DstP.mjs 0 B → 792 B (+792 B) -
shared/create-nuxt.DsQW-n5K.mjs 0 B → 294 B (+294 B) -

Removed

Asset File Size % Changed
shared/create-nuxt.KL9ugVZV.mjs 2.02 MB → 0 B (-2.02 MB) -100%
shared/create-nuxt.CmFqvJkI.mjs 1.17 MB → 0 B (-1.17 MB) -100%
shared/create-nuxt.COVR4bTQ.mjs 964.65 kB → 0 B (-964.65 kB) -100%
shared/create-nuxt.5PBv8cve.mjs 108.11 kB → 0 B (-108.11 kB) -100%
shared/create-nuxt.CXdKBgrj.mjs 18.91 kB → 0 B (-18.91 kB) -100%
shared/create-nuxt.DxguKsRg.mjs 15.27 kB → 0 B (-15.27 kB) -100%
shared/create-nuxt.B71vGbOF.mjs 4.07 kB → 0 B (-4.07 kB) -100%
shared/create-nuxt.CmohqI63.mjs 4.06 kB → 0 B (-4.06 kB) -100%
shared/create-nuxt.Drk1Byyi.mjs 3.9 kB → 0 B (-3.9 kB) -100%
shared/create-nuxt.B6dGcd5o.mjs 945 B → 0 B (-945 B) -100%
shared/create-nuxt.qG8SP-dG.mjs 836 B → 0 B (-836 B) -100%
shared/create-nuxt.BNIuJ6a6.mjs 792 B → 0 B (-792 B) -100%
shared/create-nuxt.wER2Sq2O.mjs 294 B → 0 B (-294 B) -100%

Bigger

Asset File Size % Changed
chunks/dev.mjs 28.21 kB → 28.22 kB (+7 B) +0.02%

Smaller

Asset File Size % Changed
chunks/index2.mjs 197.8 kB → 197.35 kB (-464 B) -0.23%

Unchanged

Asset File Size % Changed
index.mjs 1.07 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
chunks/add.mjs 6.89 kB 0%
chunks/analyze.mjs 3.35 kB 0%
chunks/build.mjs 2.04 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 811 B 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 492 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 1.04 kB 0%
chunks/preview.mjs 3.58 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 2.06 kB 0%
chunks/upgrade.mjs 6.28 kB 0%
chunks/prompt.mjs 42.91 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/jiti.mjs 305 B 0%
chunks/index3.mjs 71.97 kB 0%
chunks/add2.mjs 12.08 kB 0%
chunks/search.mjs 45.85 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 145.67 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 5.85 kB 0%
chunks/index6.mjs 6.24 kB 0%
chunks/index7.mjs 50.51 kB 0%
chunks/index8.mjs 900.74 kB 0%
shared/create-nuxt.BSm0_9Hr.mjs 107 B 0%
shared/create-nuxt.BjhZEm2-.mjs 1.75 kB 0%
shared/create-nuxt.Vk1IrVtB.mjs 26.96 kB 0%
shared/create-nuxt.4t9faemh.mjs 43.64 kB 0%

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 11, 2025

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@952
npm i https://pkg.pr.new/nuxi@952
npm i https://pkg.pr.new/@nuxt/cli@952

commit: 79c50cc

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 11, 2025

CodSpeed Performance Report

Merging #952 will not alter performance

Comparing refactor/socket-path (79c50cc) with main (e3fb91b)

Summary

✅ 2 untouched benchmarks

@danielroe danielroe merged commit c7c4dd1 into main Jul 11, 2025
14 checks passed
@danielroe danielroe deleted the refactor/socket-path branch July 11, 2025 13:24
@github-actions github-actions bot mentioned this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant