fix(ci): Give correct permissions to PR size compare workflow#999
Merged
fix(ci): Give correct permissions to PR size compare workflow#999
Conversation
Only with `pull_request_target` does the action actually have the ability to make PR comments.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage ? 27.30%
=======================================
Files ? 74
Lines ? 3897
Branches ? 214
=======================================
Hits ? 1064
Misses ? 2804
Partials ? 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #999 will not alter performanceComparing Summary
|
Closed
6 tasks
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Only with
pull_request_targetdoes the action actually have the ability to make PR comments.Please note:
pull_request_targetis dangerous in general. In this case, each job has restricted permissions defined, so it can be safely used here without a risk of anyone pushing unauthorized code. (pull-requests: writedoes not allow merging a PR).You can't see the issue in this PR, because the new permissions will only apply after this PR is merged, but GitHub doesn't run the old action because it changed. You can see it in the checks tab of my other PR #998.