Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): transform virtual templates#4512

Merged
pi0 merged 1 commit intomainfrom
fix/virtual-transform
Apr 22, 2022
Merged

fix(vite): transform virtual templates#4512
pi0 merged 1 commit intomainfrom
fix/virtual-transform

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#11791, resolves nuxt/nuxt#13214

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Starting the prefix with \0 seems to short-circuit the vite/rollup transform process, meaning future transform plugins weren't being run. This change means we can process virtual files in the same way we can the rest of source materials for the build.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 21, 2022
@danielroe danielroe requested a review from pi0 April 21, 2022 20:00
@danielroe danielroe self-assigned this Apr 21, 2022
@netlify
Copy link

netlify bot commented Apr 21, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 561f99f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6261b7d6fb737e00081ff473

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import typescript files inside virtual templates/create typescript templates Can't add Vue files as templates with Vite

2 participants