Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): don't match across newlines#4596

Merged
pi0 merged 1 commit intomainfrom
fix/newline-assets
Apr 25, 2022
Merged

fix(vite): don't match across newlines#4596
pi0 merged 1 commit intomainfrom
fix/newline-assets

Conversation

@danielroe
Copy link
Member

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In diagnosing another issue, I hit an edge condition that this resolves.

@danielroe danielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Apr 25, 2022
@danielroe danielroe requested a review from pi0 April 25, 2022 14:57
@danielroe danielroe self-assigned this Apr 25, 2022
@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 28c23f9
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6266b6d12624ed0009b3894e

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... However, at least showing an example to PR description could be nice this change is clueless.

@pi0 pi0 merged commit b8d2e64 into main Apr 25, 2022
@pi0 pi0 deleted the fix/newline-assets branch April 25, 2022 16:55
@pi0 pi0 mentioned this pull request May 2, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants